From: Greg KH <gregkh@linuxfoundation.org>
To: lustre-devel@lists.lustre.org
Subject: [lustre-devel] [PATCH 1/2] staging: lustre: llite: use u64 instead of loff_t in lov_object_fiemap()
Date: Wed, 9 Nov 2016 17:05:07 +0100 [thread overview]
Message-ID: <20161109160507.GD9111@kroah.com> (raw)
In-Reply-To: <B830560B-ED95-40ED-B612-39827A314B7F@intel.com>
On Tue, Nov 08, 2016 at 12:13:59PM +0000, Xu, Bobijam wrote:
> Change loff_t to u64 in lov_object_fiemap() since loff_t is a signed
> value type.
>
> Otherwise there could be an overflow in
> drivers/staging/lustre/lustre/lov/lov_object.c:1241 lov_object_fiemap()
> warn: signed overflow undefined. 'fm_start + fm_length < fm_start'
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Bobi Jam <bobijam.xu@intel.com>
> ---
> drivers/staging/lustre/lustre/lov/lov_object.c | 38 +++++++++++++-------------
> 1 file changed, 19 insertions(+), 19 deletions(-)
Why did you not cc: the maintainers of this filesystem with these
patches?
Please resend them both and do so.
thanks,
greg k-h
parent reply other threads:[~2016-11-09 16:05 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <B830560B-ED95-40ED-B612-39827A314B7F@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161109160507.GD9111@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=lustre-devel@lists.lustre.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox