From: Matthew Wilcox <willy@infradead.org>
To: lustre-devel@lists.lustre.org
Subject: [lustre-devel] [PATCH] staging: lustre: Change return type to vm_fault_t
Date: Sat, 21 Apr 2018 20:20:52 -0700 [thread overview]
Message-ID: <20180422032052.GH14610@bombadil.infradead.org> (raw)
In-Reply-To: <20180421221723.GA3054@jordon-HP-15-Notebook-PC>
On Sun, Apr 22, 2018 at 03:47:24AM +0530, Souptick Joarder wrote:
> @@ -261,7 +261,7 @@ static inline int to_fault_error(int result)
> * \retval VM_FAULT_ERROR on general error
> * \retval NOPAGE_OOM not have memory for allocate new page
> */
> -static int ll_fault0(struct vm_area_struct *vma, struct vm_fault *vmf)
> +static vm_fault_t ll_fault0(struct vm_area_struct *vma, struct vm_fault *vmf)
> {
> struct lu_env *env;
> struct cl_io *io;
Did you compile-test this with the sparse changes? Because I can see
a problem here:
env = cl_env_get(&refcheck);
if (IS_ERR(env))
return PTR_ERR(env);
> @@ -269,7 +269,7 @@ static int ll_fault0(struct vm_area_struct *vma, struct vm_fault *vmf)
> struct page *vmpage;
> unsigned long ra_flags;
> int result = 0;
> - int fault_ret = 0;
> + vm_fault_t fault_ret = 0;
What odd indentation ...
next prev parent reply other threads:[~2018-04-22 3:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-21 22:17 [lustre-devel] [PATCH] staging: lustre: Change return type to vm_fault_t Souptick Joarder
2018-04-22 3:20 ` Matthew Wilcox [this message]
2018-04-23 16:42 ` Souptick Joarder
2018-04-23 17:35 ` Matthew Wilcox
2018-04-23 18:08 ` Souptick Joarder
2018-04-23 19:15 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180422032052.GH14610@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=lustre-devel@lists.lustre.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).