* [PATCH nf-next] netfilter: ipvs: do not printk on netns creation
@ 2021-03-30 6:42 Florian Westphal
2021-04-02 3:07 ` Julian Anastasov
2021-04-03 18:17 ` Pablo Neira Ayuso
0 siblings, 2 replies; 4+ messages in thread
From: Florian Westphal @ 2021-03-30 6:42 UTC (permalink / raw)
To: netfilter-devel; +Cc: lvs-devel, ja, horms, Florian Westphal
This causes dmesg spew during normal operation, so remove this.
Signed-off-by: Florian Westphal <fw@strlen.de>
---
net/netfilter/ipvs/ip_vs_ftp.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/net/netfilter/ipvs/ip_vs_ftp.c b/net/netfilter/ipvs/ip_vs_ftp.c
index cf925906f59b..ef1f45e43b63 100644
--- a/net/netfilter/ipvs/ip_vs_ftp.c
+++ b/net/netfilter/ipvs/ip_vs_ftp.c
@@ -591,8 +591,6 @@ static int __net_init __ip_vs_ftp_init(struct net *net)
ret = register_ip_vs_app_inc(ipvs, app, app->protocol, ports[i]);
if (ret)
goto err_unreg;
- pr_info("%s: loaded support on port[%d] = %u\n",
- app->name, i, ports[i]);
}
return 0;
--
2.26.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH nf-next] netfilter: ipvs: do not printk on netns creation
2021-03-30 6:42 [PATCH nf-next] netfilter: ipvs: do not printk on netns creation Florian Westphal
@ 2021-04-02 3:07 ` Julian Anastasov
2021-04-02 9:28 ` Simon Horman
2021-04-03 18:17 ` Pablo Neira Ayuso
1 sibling, 1 reply; 4+ messages in thread
From: Julian Anastasov @ 2021-04-02 3:07 UTC (permalink / raw)
To: Florian Westphal
Cc: netfilter-devel, lvs-devel, Simon Horman, Pablo Neira Ayuso
Hello,
On Tue, 30 Mar 2021, Florian Westphal wrote:
> This causes dmesg spew during normal operation, so remove this.
>
> Signed-off-by: Florian Westphal <fw@strlen.de>
Looks good to me, thanks!
Acked-by: Julian Anastasov <ja@ssi.bg>
> ---
> net/netfilter/ipvs/ip_vs_ftp.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/net/netfilter/ipvs/ip_vs_ftp.c b/net/netfilter/ipvs/ip_vs_ftp.c
> index cf925906f59b..ef1f45e43b63 100644
> --- a/net/netfilter/ipvs/ip_vs_ftp.c
> +++ b/net/netfilter/ipvs/ip_vs_ftp.c
> @@ -591,8 +591,6 @@ static int __net_init __ip_vs_ftp_init(struct net *net)
> ret = register_ip_vs_app_inc(ipvs, app, app->protocol, ports[i]);
> if (ret)
> goto err_unreg;
> - pr_info("%s: loaded support on port[%d] = %u\n",
> - app->name, i, ports[i]);
> }
> return 0;
>
> --
> 2.26.3
Regards
--
Julian Anastasov <ja@ssi.bg>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH nf-next] netfilter: ipvs: do not printk on netns creation
2021-04-02 3:07 ` Julian Anastasov
@ 2021-04-02 9:28 ` Simon Horman
0 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2021-04-02 9:28 UTC (permalink / raw)
To: Julian Anastasov
Cc: Florian Westphal, netfilter-devel, lvs-devel, Pablo Neira Ayuso
On Fri, Apr 02, 2021 at 06:07:23AM +0300, Julian Anastasov wrote:
>
> Hello,
>
> On Tue, 30 Mar 2021, Florian Westphal wrote:
>
> > This causes dmesg spew during normal operation, so remove this.
> >
> > Signed-off-by: Florian Westphal <fw@strlen.de>
>
> Looks good to me, thanks!
>
> Acked-by: Julian Anastasov <ja@ssi.bg>
Reviewed-by: Simon Horman <horms@verge.net.au>
>
> > ---
> > net/netfilter/ipvs/ip_vs_ftp.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/net/netfilter/ipvs/ip_vs_ftp.c b/net/netfilter/ipvs/ip_vs_ftp.c
> > index cf925906f59b..ef1f45e43b63 100644
> > --- a/net/netfilter/ipvs/ip_vs_ftp.c
> > +++ b/net/netfilter/ipvs/ip_vs_ftp.c
> > @@ -591,8 +591,6 @@ static int __net_init __ip_vs_ftp_init(struct net *net)
> > ret = register_ip_vs_app_inc(ipvs, app, app->protocol, ports[i]);
> > if (ret)
> > goto err_unreg;
> > - pr_info("%s: loaded support on port[%d] = %u\n",
> > - app->name, i, ports[i]);
> > }
> > return 0;
> >
> > --
> > 2.26.3
>
> Regards
>
> --
> Julian Anastasov <ja@ssi.bg>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH nf-next] netfilter: ipvs: do not printk on netns creation
2021-03-30 6:42 [PATCH nf-next] netfilter: ipvs: do not printk on netns creation Florian Westphal
2021-04-02 3:07 ` Julian Anastasov
@ 2021-04-03 18:17 ` Pablo Neira Ayuso
1 sibling, 0 replies; 4+ messages in thread
From: Pablo Neira Ayuso @ 2021-04-03 18:17 UTC (permalink / raw)
To: Florian Westphal; +Cc: netfilter-devel, lvs-devel, ja, horms
On Tue, Mar 30, 2021 at 08:42:32AM +0200, Florian Westphal wrote:
> This causes dmesg spew during normal operation, so remove this.
Applied, thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-04-03 18:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-30 6:42 [PATCH nf-next] netfilter: ipvs: do not printk on netns creation Florian Westphal
2021-04-02 3:07 ` Julian Anastasov
2021-04-02 9:28 ` Simon Horman
2021-04-03 18:17 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).