From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [PATCH net] ipvs: ignore IP_VS_SVC_F_HASHED flag when adding service Date: Thu, 27 May 2021 13:07:35 +0200 Message-ID: <20210527110735.GA6710@salvia> References: <20210524195457.125514-1-ja@ssi.bg> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <20210524195457.125514-1-ja@ssi.bg> List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julian Anastasov Cc: Simon Horman , lvs-devel@vger.kernel.org, netfilter-devel@vger.kernel.org On Mon, May 24, 2021 at 10:54:57PM +0300, Julian Anastasov wrote: > syzbot reported memory leak [1] when adding service with > HASHED flag. We should ignore this flag both from sockopt > and netlink provided data, otherwise the service is not > hashed and not visible while releasing resources. > > [1] > BUG: memory leak > unreferenced object 0xffff888115227800 (size 512): > comm "syz-executor263", pid 8658, jiffies 4294951882 (age 12.560s) > hex dump (first 32 bytes): > 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ > 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ > backtrace: > [] kmalloc include/linux/slab.h:556 [inline] > [] kzalloc include/linux/slab.h:686 [inline] > [] ip_vs_add_service+0x598/0x7c0 net/netfilter/ipvs/ip_vs_ctl.c:1343 > [] do_ip_vs_set_ctl+0x810/0xa40 net/netfilter/ipvs/ip_vs_ctl.c:2570 > [] nf_setsockopt+0x68/0xa0 net/netfilter/nf_sockopt.c:101 > [] ip_setsockopt+0x259/0x1ff0 net/ipv4/ip_sockglue.c:1435 > [] raw_setsockopt+0x18c/0x1b0 net/ipv4/raw.c:857 > [] __sys_setsockopt+0x1b0/0x360 net/socket.c:2117 > [] __do_sys_setsockopt net/socket.c:2128 [inline] > [] __se_sys_setsockopt net/socket.c:2125 [inline] > [] __x64_sys_setsockopt+0x22/0x30 net/socket.c:2125 > [] do_syscall_64+0x3a/0xb0 arch/x86/entry/common.c:47 > [] entry_SYSCALL_64_after_hwframe+0x44/0xae Applied, thanks.