From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH][next] treewide: uapi: Replace zero-length arrays with flexible-array members Date: Mon, 27 Jun 2022 12:53:43 -0700 Message-ID: <20220627125343.44e24c41@hermes.local> References: <20220627180432.GA136081@embeddedor> Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=k/l4LcE4w+6LYrCo6/Ek+44r04gbnpHm9yyPA0qKR6A=; b=ryYp2naL1201DMNfPmSbpexCs+zqiLsBQDBXHc9esFHxBJ8Ep2LLrsgHtxJtosu2+J 1iBYfvQQXv6NYwKQ2qXQCc4mHXYQGPYeeUC3hu2OgPUPjZXH+3Hi6Zqo5SyTeGerBVQA p1Bh5daOuP6Q9UMRPxlj6vxZpUjBpxOPEYhjttl3pP6gtksJnO1wA5G3ERXmm3iOhFrs MlyYmEaZt8I/cdZ0xlE1RQA9V/oE3k4e+iV7r8nrUlXmSvlRImOQktUmXD254MFh7ceV 2zbWTxt+/QD0MTYLBrv8xqePAliI2A59OkEqXOPrksIatTeOcW53aiRz+65e7KopsoX+ 3osw== In-Reply-To: <20220627180432.GA136081@embeddedor> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Content-Type: text/plain; charset="utf-8" To: "Gustavo A. R. Silva" Cc: nvdimm@lists.linux.dev, alsa-devel@alsa-project.org, kvm@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, dm-devel@redhat.com, target-devel@vger.kernel.org, linux-mtd@lists.infradead.org, linux-hardening@vger.kernel.org, linux1394-devel@lists.sourceforge.net, linux-stm32@st-md-mailman.stormreply.com, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-rdma@vger.kernel.org, x86@kernel.org, kasan-dev@googlegroups.com, lvs-devel@vger.kernel.org, coreteam@netfilter.org, v9fs-developer@lists.sourceforge.net, Kees Cook , intel-gfx@lists.freedesktop.org, linux-can@vger.kernel.org, linux-raid@vger.kernel.org, linux-m68k@lists.linux-m68k.org, virtualization@lists.linux-foundation.org, io-uring@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-mmc@vger.kern On Mon, 27 Jun 2022 20:04:32 +0200 "Gustavo A. R. Silva" wrote: > There is a regular need in the kernel to provide a way to declare > having a dynamically sized set of trailing elements in a structure. > Kernel code should always use =E2=80=9Cflexible array members=E2=80=9D[1]= for these > cases. The older style of one-element or zero-length arrays should > no longer be used[2]. >=20 > This code was transformed with the help of Coccinelle: > (linux-5.19-rc2$ spatch --jobs $(getconf _NPROCESSORS_ONLN) --sp-file scr= ipt.cocci --include-headers --dir . > output.patch) >=20 > @@ > identifier S, member, array; > type T1, T2; > @@ >=20 > struct S { > ... > T1 member; > T2 array[ > - 0 > ]; > }; >=20 > -fstrict-flex-arrays=3D3 is coming and we need to land these changes > to prevent issues like these in the short future: >=20 > ../fs/minix/dir.c:337:3: warning: 'strcpy' will always overflow; destinat= ion buffer has size 0, > but the source string has length 2 (including NUL byte) [-Wfortify-source] > strcpy(de3->name, "."); > ^ >=20 > Since these are all [0] to [] changes, the risk to UAPI is nearly zero. If > this breaks anything, we can use a union with a new member name. >=20 > [1] https://en.wikipedia.org/wiki/Flexible_array_member > [2] https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-le= ngth-and-one-element-arrays >=20 > Link: https://github.com/KSPP/linux/issues/78 > Build-tested-by: https://lore.kernel.org/lkml/62b675ec.wKX6AOZ6cbE71vtF%2= 5lkp@intel.com/ > Signed-off-by: Gustavo A. R. Silva Thanks this fixes warning with gcc-12 in iproute2. In function =E2=80=98xfrm_algo_parse=E2=80=99, inlined from =E2=80=98xfrm_state_modify.constprop=E2=80=99 at xfrm_stat= e.c:573:5: xfrm_state.c:162:32: warning: writing 1 byte into a region of size 0 [-Wstr= ingop-overflow=3D] 162 | buf[j] =3D val; | ~~~~~~~^~~~~