lvs-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ratheesh Kannoth <rkannoth@marvell.com>
To: Chen Hanxiao <chenhx.fnst@fujitsu.com>
Cc: Simon Horman <horms@verge.net.au>, Julian Anastasov <ja@ssi.bg>,
	Pablo Neira Ayuso <pablo@netfilter.org>,
	Jozsef Kadlecsik <kadlec@netfilter.org>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	<netdev@vger.kernel.org>, <lvs-devel@vger.kernel.org>,
	<netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH net-next] ipvs: properly dereference pe in ip_vs_add_service
Date: Thu, 27 Jun 2024 10:37:50 +0530	[thread overview]
Message-ID: <20240627050750.GA1743080@maili.marvell.com> (raw)
In-Reply-To: <20240626081159.1405-1-chenhx.fnst@fujitsu.com>

On 2024-06-26 at 13:41:59, Chen Hanxiao (chenhx.fnst@fujitsu.com) wrote:
>
> diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/ipvs/ip_vs_ctl.c
> index b6d0dcf3a5c3..925e2143ba15 100644
> --- a/net/netfilter/ipvs/ip_vs_ctl.c
> +++ b/net/netfilter/ipvs/ip_vs_ctl.c
> @@ -1369,7 +1369,7 @@ ip_vs_add_service(struct netns_ipvs *ipvs, struct ip_vs_service_user_kern *u,
>  {
>  	int ret = 0;
>  	struct ip_vs_scheduler *sched = NULL;
> -	struct ip_vs_pe *pe = NULL;
> +	struct ip_vs_pe *pe = NULL, *tmp_pe = NULL;
Reverse xmas tree.
>  	struct ip_vs_service *svc = NULL;
>  	int ret_hooks = -1;
>
>

      parent reply	other threads:[~2024-06-27  5:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-26  8:11 [PATCH net-next] ipvs: properly dereference pe in ip_vs_add_service Chen Hanxiao
2024-06-26 17:53 ` Julian Anastasov
2024-06-27  2:57   ` 回复: " Hanxiao Chen (Fujitsu)
2024-06-27  5:07 ` Ratheesh Kannoth [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240627050750.GA1743080@maili.marvell.com \
    --to=rkannoth@marvell.com \
    --cc=chenhx.fnst@fujitsu.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@verge.net.au \
    --cc=ja@ssi.bg \
    --cc=kadlec@netfilter.org \
    --cc=kuba@kernel.org \
    --cc=lvs-devel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).