* [PATCH net-next v2] ipvs: properly dereference pe in ip_vs_add_service
@ 2024-06-27 6:15 Chen Hanxiao
2024-06-27 19:09 ` Julian Anastasov
2024-06-30 13:16 ` Simon Horman
0 siblings, 2 replies; 3+ messages in thread
From: Chen Hanxiao @ 2024-06-27 6:15 UTC (permalink / raw)
To: Simon Horman, Julian Anastasov, Pablo Neira Ayuso,
Jozsef Kadlecsik, David S . Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni
Cc: netdev, lvs-devel, netfilter-devel
Use pe directly to resolve sparse warning:
net/netfilter/ipvs/ip_vs_ctl.c:1471:27: warning: dereference of noderef expression
Fixes: 39b972231536 ("ipvs: handle connections started by real-servers")
Signed-off-by: Chen Hanxiao <chenhx.fnst@fujitsu.com>
---
v2:
use pe directly.
net/netfilter/ipvs/ip_vs_ctl.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/ipvs/ip_vs_ctl.c
index b6d0dcf3a5c3..f4384e147ee1 100644
--- a/net/netfilter/ipvs/ip_vs_ctl.c
+++ b/net/netfilter/ipvs/ip_vs_ctl.c
@@ -1459,18 +1459,18 @@ ip_vs_add_service(struct netns_ipvs *ipvs, struct ip_vs_service_user_kern *u,
if (ret < 0)
goto out_err;
- /* Bind the ct retriever */
- RCU_INIT_POINTER(svc->pe, pe);
- pe = NULL;
-
/* Update the virtual service counters */
if (svc->port == FTPPORT)
atomic_inc(&ipvs->ftpsvc_counter);
else if (svc->port == 0)
atomic_inc(&ipvs->nullsvc_counter);
- if (svc->pe && svc->pe->conn_out)
+ if (pe && pe->conn_out)
atomic_inc(&ipvs->conn_out_counter);
+ /* Bind the ct retriever */
+ RCU_INIT_POINTER(svc->pe, pe);
+ pe = NULL;
+
/* Count only IPv4 services for old get/setsockopt interface */
if (svc->af == AF_INET)
ipvs->num_services++;
--
2.39.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next v2] ipvs: properly dereference pe in ip_vs_add_service
2024-06-27 6:15 [PATCH net-next v2] ipvs: properly dereference pe in ip_vs_add_service Chen Hanxiao
@ 2024-06-27 19:09 ` Julian Anastasov
2024-06-30 13:16 ` Simon Horman
1 sibling, 0 replies; 3+ messages in thread
From: Julian Anastasov @ 2024-06-27 19:09 UTC (permalink / raw)
To: Chen Hanxiao
Cc: Simon Horman, Pablo Neira Ayuso, Jozsef Kadlecsik,
David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
netdev, lvs-devel, netfilter-devel
Hello,
On Thu, 27 Jun 2024, Chen Hanxiao wrote:
> Use pe directly to resolve sparse warning:
>
> net/netfilter/ipvs/ip_vs_ctl.c:1471:27: warning: dereference of noderef expression
>
> Fixes: 39b972231536 ("ipvs: handle connections started by real-servers")
> Signed-off-by: Chen Hanxiao <chenhx.fnst@fujitsu.com>
Looks good to me, thanks!
Acked-by: Julian Anastasov <ja@ssi.bg>
> ---
> v2:
> use pe directly.
>
> net/netfilter/ipvs/ip_vs_ctl.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/ipvs/ip_vs_ctl.c
> index b6d0dcf3a5c3..f4384e147ee1 100644
> --- a/net/netfilter/ipvs/ip_vs_ctl.c
> +++ b/net/netfilter/ipvs/ip_vs_ctl.c
> @@ -1459,18 +1459,18 @@ ip_vs_add_service(struct netns_ipvs *ipvs, struct ip_vs_service_user_kern *u,
> if (ret < 0)
> goto out_err;
>
> - /* Bind the ct retriever */
> - RCU_INIT_POINTER(svc->pe, pe);
> - pe = NULL;
> -
> /* Update the virtual service counters */
> if (svc->port == FTPPORT)
> atomic_inc(&ipvs->ftpsvc_counter);
> else if (svc->port == 0)
> atomic_inc(&ipvs->nullsvc_counter);
> - if (svc->pe && svc->pe->conn_out)
> + if (pe && pe->conn_out)
> atomic_inc(&ipvs->conn_out_counter);
>
> + /* Bind the ct retriever */
> + RCU_INIT_POINTER(svc->pe, pe);
> + pe = NULL;
> +
> /* Count only IPv4 services for old get/setsockopt interface */
> if (svc->af == AF_INET)
> ipvs->num_services++;
> --
> 2.39.1
Regards
--
Julian Anastasov <ja@ssi.bg>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next v2] ipvs: properly dereference pe in ip_vs_add_service
2024-06-27 6:15 [PATCH net-next v2] ipvs: properly dereference pe in ip_vs_add_service Chen Hanxiao
2024-06-27 19:09 ` Julian Anastasov
@ 2024-06-30 13:16 ` Simon Horman
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2024-06-30 13:16 UTC (permalink / raw)
To: Chen Hanxiao
Cc: Julian Anastasov, Pablo Neira Ayuso, Jozsef Kadlecsik,
David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
netdev, lvs-devel, netfilter-devel
On Thu, Jun 27, 2024 at 02:15:15PM +0800, Chen Hanxiao wrote:
> Use pe directly to resolve sparse warning:
>
> net/netfilter/ipvs/ip_vs_ctl.c:1471:27: warning: dereference of noderef expression
>
> Fixes: 39b972231536 ("ipvs: handle connections started by real-servers")
> Signed-off-by: Chen Hanxiao <chenhx.fnst@fujitsu.com>
Acked-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-06-30 13:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-27 6:15 [PATCH net-next v2] ipvs: properly dereference pe in ip_vs_add_service Chen Hanxiao
2024-06-27 19:09 ` Julian Anastasov
2024-06-30 13:16 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).