lvs-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Cezar Sá Espinola" <cezarsa@gmail.com>
To: lvs-devel@vger.kernel.org
Subject: Possibility of adding a new netlink command to dump everything
Date: Mon, 26 Oct 2020 12:27:37 -0300	[thread overview]
Message-ID: <CA++F93g_WfKbVHLMUFYgQbR63o2-s8Ky_W9Z85qsFM77OaweEQ@mail.gmail.com> (raw)

Hi all. This is my first message here and also my first attempt at kernel
development so I'm a bit nervous and afraid I'm doing something wrong.

The last few days I've been toying with a patch to IPVS to allow me to use
netlink to dump all services and all its destinations in a single call.

The motivation for this came after profiling a kubernetes node machine with a
few thousand IPVS services each with an average of two destinations. The
component responsible for ensuring that the IPVS rules are correct always needs
a fresh dump of all services with all destinations and currently this is
accomplished by issuing a IPVS_CMD_GET_SERVICE generic netlink dump command
followed by multiple IPVS_CMD_GET_DEST dump commands.

The patch in question adds a new netlink command IPVS_CMD_GET_SERVICE_DEST
which dumps all services where each service is followed by a dump of its
destinations. It's working now on my machine and some preliminary experiments
show me that there's a significant performance improvement in switching to a
single call to dump everything. However, I have some questions that I'd like to
talk about before trying to submit it.

1. First of all is such a patch adding a new command something desirable and
could it possibly be merged or should I just drop it?

2. I can see that besides the generic netlink interface there's also another
interface based on getsockopt options, should the patch also add a new socket
option or is it okay for this new functionality to be exclusive to generic
netlink?

3. Should this go forward, any advice on my next steps? Should I simply send the
patch here?

Thank you for your time!

             reply	other threads:[~2020-10-26 15:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-26 15:27 Cezar Sá Espinola [this message]
2020-10-26 19:35 ` Possibility of adding a new netlink command to dump everything Julian Anastasov
2020-10-26 19:47   ` Cezar Sá Espinola

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA++F93g_WfKbVHLMUFYgQbR63o2-s8Ky_W9Z85qsFM77OaweEQ@mail.gmail.com \
    --to=cezarsa@gmail.com \
    --cc=lvs-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).