From: sashiko-bot@kernel.org
To: a0282524688@gmail.com
Cc: lee@kernel.org, mfd@lists.linux.dev
Subject: Re: [PATCH v7 09/10] mfd: nct6694: Introduce regmap-based transport abstraction
Date: Fri, 21 Aug 2026 03:52:01 +0000 [thread overview]
Message-ID: <20260821035201.C1A6F1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260821033505.4017901-10-a0282524688@gmail.com>
> From: Ming Yu <a0282524688@gmail.com>
>
> Sub-device drivers call into the USB transport directly, so a second
> transport cannot be added without touching all of them.
>
> Wrap the transport behind a regmap bus and let the sub-device drivers
> reach the firmware only through nct6694_{read,write}_msg(). The command
> header maps onto the regmap bulk accessors by packing the host control
> byte, the module id and the 16-bit offset into a single 32-bit register.
>
> Add nct6694_write_read_msg() for the commands that transmit a request
> and read the reply back within the same firmware message, and use it for
> the I2C deliver command.
>
> Signed-off-by: Ming Yu <a0282524688@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260821033505.4017901-1-a0282524688@gmail.com?part=9
next prev parent reply other threads:[~2026-08-21 3:52 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260821033505.4017901-1-a0282524688@gmail.com>
2026-08-21 3:34 ` [PATCH v7 01/10] mfd: nct6694: Move module type macros to shared header a0282524688
2026-08-21 3:45 ` sashiko-bot
2026-08-21 3:34 ` [PATCH v7 02/10] mfd: nct6694: Refactor USB-specific data into nct6694_usb_data a0282524688
2026-08-21 3:48 ` sashiko-bot
2026-09-03 9:53 ` Lee Jones
2026-08-21 3:34 ` [PATCH v7 03/10] mfd: nct6694: Rename USB transport functions with _usb_ prefix a0282524688
2026-08-21 3:40 ` sashiko-bot
2026-08-21 3:34 ` [PATCH v7 04/10] mfd: nct6694: Rename driver to nct6694-usb and update Kconfig a0282524688
2026-08-21 3:43 ` sashiko-bot
2026-09-03 10:24 ` Lee Jones
2026-09-10 6:04 ` Ming Yu
2026-08-21 3:35 ` [PATCH v7 05/10] mfd: nct6694: Extract core device management into a separate module a0282524688
2026-08-21 3:45 ` sashiko-bot
2026-09-03 10:42 ` Lee Jones
2026-08-21 3:35 ` [PATCH v7 06/10] mfd: nct6694: Transfer command payloads via a dedicated DMA buffer a0282524688
2026-08-21 3:48 ` sashiko-bot
2026-09-03 11:09 ` Lee Jones
2026-09-03 11:12 ` Lee Jones
2026-08-21 3:35 ` [PATCH v7 07/10] mfd: nct6694: Validate the interrupt IN endpoint a0282524688
2026-08-21 3:48 ` sashiko-bot
2026-09-03 11:27 ` Lee Jones
2026-08-21 3:35 ` [PATCH v7 08/10] mfd: nct6694: Submit the interrupt URB after the core is registered a0282524688
2026-08-21 3:48 ` sashiko-bot
2026-09-03 11:27 ` Lee Jones
2026-08-21 3:35 ` [PATCH v7 09/10] mfd: nct6694: Introduce regmap-based transport abstraction a0282524688
2026-08-21 3:52 ` sashiko-bot [this message]
2026-08-21 3:35 ` [PATCH v7 10/10] mfd: nct6694: Add Host Interface (HIF) eSPI transport driver a0282524688
2026-08-21 3:50 ` sashiko-bot
2026-09-03 9:38 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260821035201.C1A6F1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=a0282524688@gmail.com \
--cc=lee@kernel.org \
--cc=mfd@lists.linux.dev \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).