From: sashiko-bot@kernel.org
To: "Lee Jones" <lee@kernel.org>, mfd@lists.linux.dev
Subject: Re: [PATCH 18/28] mfd: loongson-se: Zero-allocate driver data and initialise engine completions in probe
Date: Wed, 21 Oct 2026 12:22:34 +0000 [thread overview]
Message-ID: <sashiko-outbox-180237@kernel.org> (raw)
In-Reply-To: <20261021121245.3111563-18-lee@kernel.org>
> loongson_se_probe() allocates struct loongson_se using devm_kmalloc(),
> leaving the se->engines array uninitialised until child MFD drivers
> later invoke loongson_se_init_engine(). Meanwhile, hardware interrupts
> are unmasked and se_irq_handler() is registered during probe. Any
> engine interrupt arriving before loongson_se_init_engine() runs causes
> se_irq_handler() to call complete() on an uninitialised completion
> structure.
>
> Allocate struct loongson_se with devm_kzalloc() and initialise all
> engine completion structures in loongson_se_probe() before registering
> interrupt handlers.
>
> Fixes: e551fa3159e3 ("mfd: Add support for Loongson Security Engine chip controller")
> Closes: https://sashiko.dev/#/bug/linux-ad9310d7-13b2-4a4a-ad7d-78a4c612c78c
> Cc: stable@vger.kernel.org
> Signed-off-by: Lee Jones <lee@kernel.org>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261021121245.3111563-1-lee@kernel.org?part=18
next prev parent reply other threads:[~2026-10-21 12:22 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 12:09 [PATCH 01/28] mfd: nct6694: Allocate USB DMA buffers with kzalloc_obj() Lee Jones
2026-10-21 12:09 ` [PATCH 02/28] mfd: ls2kbmc: Unregister GPIO GSI via devm_add_action_or_reset() Lee Jones
2026-10-21 12:21 ` sashiko-bot
2026-10-21 13:57 ` Andy Shevchenko
2026-10-21 16:34 ` Lee Jones
2026-10-21 16:50 ` Andy Shevchenko
2026-10-21 14:00 ` Andy Shevchenko
2026-10-26 3:21 ` Binbin Zhou
2026-10-21 12:09 ` [PATCH 03/28] mfd: ls2kbmc: Cancel reset work on teardown via devm_work_autocancel() Lee Jones
2026-10-21 12:21 ` sashiko-bot
2026-10-21 13:59 ` Andy Shevchenko
2026-10-26 3:22 ` Binbin Zhou
2026-10-21 12:09 ` [PATCH 04/28] mfd: ls2kbmc: Allocate simplefb platform_data on the heap Lee Jones
2026-10-21 12:20 ` sashiko-bot
2026-10-21 13:58 ` Andy Shevchenko
2026-10-26 4:36 ` Binbin Zhou
2026-10-21 12:09 ` [PATCH 05/28] mfd: bd96801: Allocate watchdog IRQ resource " Lee Jones
2026-10-21 12:20 ` sashiko-bot
2026-10-26 6:56 ` Matti Vaittinen
2026-10-26 12:18 ` Lee Jones
2026-10-21 12:09 ` [PATCH 06/28] mfd: ti_am335x_tscadc: Retrieve parent driver data via dev_get_drvdata() Lee Jones
2026-10-21 12:21 ` sashiko-bot
2026-10-21 12:09 ` [PATCH 07/28] mfd: db8500-prcmu: Make AB8500 cell and IRQ resource static Lee Jones
2026-10-21 12:23 ` sashiko-bot
2026-10-21 23:41 ` Linus Walleij
2026-10-21 12:09 ` [PATCH 08/28] mfd: nct6694: Do not resubmit interrupt URB on endpoint stall (-EPIPE) Lee Jones
2026-10-21 12:20 ` sashiko-bot
2026-10-21 12:09 ` [PATCH 09/28] mfd: cgbc: Zero-initialise version buffer in cgbc_get_version() Lee Jones
2026-10-21 12:20 ` sashiko-bot
2026-10-21 16:38 ` Thomas Richard (congatec GmbH)
2026-10-21 17:18 ` Thomas Richard (congatec GmbH)
2026-10-21 12:09 ` [PATCH 10/28] mfd: ioc3: Request parent IRQ via request_irq() and free before domain removal Lee Jones
2026-10-21 12:24 ` sashiko-bot
2026-10-21 12:09 ` [PATCH 11/28] mfd: intel-lpss: Remove registered MFD child devices on probe failure Lee Jones
2026-10-21 12:20 ` sashiko-bot
2026-10-21 14:01 ` Andy Shevchenko
2026-10-21 16:33 ` Lee Jones
2026-10-21 16:49 ` Andy Shevchenko
2026-10-21 17:01 ` Andy Shevchenko
2026-10-21 12:09 ` [PATCH 12/28] mfd: max8907: Manage power-off handler via devm_register_sys_off_handler() Lee Jones
2026-10-21 12:21 ` sashiko-bot
2026-10-21 12:09 ` [PATCH 13/28] mfd: twl-core: Clear pm_power_off callback in twl_remove() Lee Jones
2026-10-21 12:22 ` sashiko-bot
2026-10-21 12:09 ` [PATCH 14/28] mfd: twl-core: Clear twl_priv pointer on teardown and probe failure Lee Jones
2026-10-21 12:24 ` sashiko-bot
2026-10-21 12:09 ` [PATCH 15/28] mfd: loongson-se: Check return value of dma_set_mask_and_coherent() Lee Jones
2026-10-21 12:19 ` sashiko-bot
2026-10-26 9:25 ` Qunqin Zhao
2026-10-21 12:09 ` [PATCH 16/28] mfd: loongson-se: Zero-initialise controller command structures Lee Jones
2026-10-21 12:21 ` sashiko-bot
2026-10-26 9:32 ` Qunqin Zhao
2026-10-21 12:09 ` [PATCH 17/28] mfd: loongson-se: Reinitialise completions and wait uninterruptibly for commands Lee Jones
2026-10-21 12:22 ` sashiko-bot
2026-10-27 2:40 ` Qunqin Zhao
2026-10-21 12:09 ` [PATCH 18/28] mfd: loongson-se: Zero-allocate driver data and initialise engine completions in probe Lee Jones
2026-10-21 12:22 ` sashiko-bot [this message]
2026-10-27 2:43 ` Qunqin Zhao
2026-10-21 12:09 ` [PATCH 19/28] mfd: loongson-se: Prevent out-of-bounds engine access in se_irq_handler() Lee Jones
2026-10-21 12:22 ` sashiko-bot
2026-10-27 2:47 ` Qunqin Zhao
2026-10-21 12:09 ` [PATCH 20/28] mfd: loongson-se: Stop controller and mask interrupts on teardown and shutdown Lee Jones
2026-10-21 12:25 ` sashiko-bot
2026-10-27 3:56 ` Qunqin Zhao
2026-10-21 12:09 ` [PATCH 21/28] mfd: loongson-se: Validate engine ID, DMA buffer size, and IRQ registration Lee Jones
2026-10-21 12:22 ` sashiko-bot
2026-10-27 3:25 ` Qunqin Zhao
2026-10-21 12:09 ` [PATCH 22/28] mfd: abx500-core: Unregister device ops on devm release Lee Jones
2026-10-21 12:23 ` sashiko-bot
2026-10-21 23:42 ` Linus Walleij
2026-10-21 12:09 ` [PATCH 23/28] mfd: ab8500-core: Register sysfs attribute groups via devm_device_add_group() Lee Jones
2026-10-21 12:24 ` sashiko-bot
2026-10-21 23:41 ` Linus Walleij
2026-10-21 12:09 ` [PATCH 24/28] mfd: tps65217: Manage IRQ domain teardown via devres Lee Jones
2026-10-21 12:24 ` sashiko-bot
2026-10-21 12:09 ` [PATCH 25/28] mfd: mt6397: Manage IRQ domain lifecycle with devres Lee Jones
2026-10-21 12:28 ` sashiko-bot
2026-10-21 12:09 ` [PATCH 26/28] mfd: mt6397: Unregister PM notifier on probe failure and unbind Lee Jones
2026-10-21 12:23 ` sashiko-bot
2026-10-21 12:09 ` [PATCH 28/28] mfd: ti_am335x_tscadc: Remove redundant ti_tscadc_dev_get() helper Lee Jones
2026-10-21 12:23 ` sashiko-bot
2026-10-21 14:02 ` Andy Shevchenko
2026-10-21 16:52 ` Dmitry Torokhov
2026-10-21 19:19 ` Jonathan Cameron
2026-10-21 12:20 ` [PATCH 01/28] mfd: nct6694: Allocate USB DMA buffers with kzalloc_obj() sashiko-bot
2026-10-21 12:31 ` [PATCH 00/28] mfd: Assorted resource lifetime, teardown, and error-handling fixes Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-180237@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=lee@kernel.org \
--cc=mfd@lists.linux.dev \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).