From: sashiko-bot@kernel.org
To: "Uwe Kleine-König (The Capable Hub)" <u.kleine-koenig@baylibre.com>
Cc: mfd@lists.linux.dev, lee@kernel.org
Subject: Re: [PATCH v4 12/20] mfd: Use named initializers for arrays of i2c_device_id
Date: Tue, 10 Nov 2026 22:00:47 +0000 [thread overview]
Message-ID: <sashiko-outbox-207802@kernel.org> (raw)
In-Reply-To: <db421752980323be4dfb4733b6379db7da24bc11.1794347059.git.u.kleine-koenig@baylibre.com>
> While being less compact, using named initializers allows to more easily
> see which members of the structs are assigned which value without having
> to lookup the declaration of the struct. And it's also more robust
> against changes to the struct definition.
>
> The mentioned robustness is relevant for a planned change to struct
> i2c_device_id that replaces .driver_data by an anonymous union.
>
> This patch doesn't modify the compiled arrays, only their representation
> in source form benefits.
>
> Reviewed-by: André Draszik <andre.draszik@linaro.org> # for Maxim MAX77759
> Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> Reviewed-by: Linus Walleij <linusw@kernel.org>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1794347059.git.u.kleine-koenig@baylibre.com?part=12
next prev parent reply other threads:[~2026-11-10 22:00 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 21:54 [PATCH v4 00/20] mfd: Use named initializers for arrays of *_device_data Uwe Kleine-König (The Capable Hub)
2026-11-10 21:54 ` [PATCH v4 01/20] mfd: bcm2835-pm: Remove member of struct bcm2835_pm that is only used locally Uwe Kleine-König (The Capable Hub)
2026-11-10 21:59 ` sashiko-bot
2026-11-11 9:30 ` Uwe Kleine-König (The Capable Hub)
2026-11-10 21:54 ` [PATCH v4 02/20] mfd: bcm2835-pm: Drop unused header Uwe Kleine-König (The Capable Hub)
2026-11-10 21:59 ` sashiko-bot
2026-11-10 21:54 ` [PATCH v4 03/20] mfd: kempld: Simplify device abstraction Uwe Kleine-König (The Capable Hub)
2026-11-10 22:07 ` sashiko-bot
2026-11-10 21:54 ` [PATCH v4 04/20] mfd: lp87565: Explicitly set driver data for the generic dt compatible Uwe Kleine-König (The Capable Hub)
2026-11-10 22:00 ` sashiko-bot
2026-11-10 21:54 ` [PATCH v4 05/20] mfd: mt6360: Drop irrelevant __maybe_unused Uwe Kleine-König (The Capable Hub)
2026-11-10 21:58 ` sashiko-bot
2026-11-10 21:54 ` [PATCH v4 06/20] mfd: rt4831: " Uwe Kleine-König (The Capable Hub)
2026-11-10 21:58 ` sashiko-bot
2026-11-10 21:54 ` [PATCH v4 07/20] mfd: loongson-se: Drop unused assignment of acpi_device_id driver data Uwe Kleine-König (The Capable Hub)
2026-11-10 21:58 ` sashiko-bot
2026-11-10 21:54 ` [PATCH v4 08/20] mfd: Drop unused assignment of i2c_device_id " Uwe Kleine-König (The Capable Hub)
2026-11-10 21:58 ` sashiko-bot
2026-11-10 21:54 ` [PATCH v4 09/20] mfd: Drop unused assignment of platform_device_id " Uwe Kleine-König (The Capable Hub)
2026-11-10 21:59 ` sashiko-bot
2026-11-10 23:05 ` Benson Leung
2026-11-10 21:54 ` [PATCH v4 10/20] mfd: Use named initializers for acpi_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-11-10 21:59 ` sashiko-bot
2026-11-11 8:45 ` Andy Shevchenko
2026-11-11 9:55 ` Uwe Kleine-König (The Capable Hub)
2026-11-11 11:50 ` Pawel Zalewski
2026-11-10 21:54 ` [PATCH v4 11/20] mfd: intel-m10-bmc-pmci: Use named initializers for dfl_device_id array Uwe Kleine-König (The Capable Hub)
2026-11-10 21:59 ` sashiko-bot
2026-11-10 21:54 ` [PATCH v4 12/20] mfd: Use named initializers for arrays of i2c_device_id Uwe Kleine-König (The Capable Hub)
2026-11-10 22:00 ` sashiko-bot [this message]
2026-11-10 21:54 ` [PATCH v4 13/20] mfd: twl6030: Use named initializers for of_device_id Uwe Kleine-König (The Capable Hub)
2026-11-10 21:59 ` sashiko-bot
2026-11-10 21:54 ` [PATCH v4 14/20] mfd: Use PCI_DEVICE* macros to initialize pci_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-11-10 22:01 ` sashiko-bot
2026-11-10 21:54 ` [PATCH v4 15/20] mfd: Use named initializers for platform_device_id array Uwe Kleine-König (The Capable Hub)
2026-11-10 21:59 ` sashiko-bot
2026-11-10 23:07 ` Benson Leung
2026-11-10 21:54 ` [PATCH v4 16/20] mfd: Unify style of acpi_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-11-10 22:00 ` sashiko-bot
2026-11-10 21:54 ` [PATCH v4 17/20] mfd: Unify style of dmi_system_id arrays Uwe Kleine-König (The Capable Hub)
2026-11-10 22:00 ` sashiko-bot
2026-11-10 21:54 ` [PATCH v4 18/20] mfd: Unify style of i2c_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-11-10 22:00 ` sashiko-bot
2026-11-10 21:54 ` [PATCH v4 19/20] mfd: Unify style of of_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-11-10 22:02 ` sashiko-bot
2026-11-11 2:15 ` Chen-Yu Tsai
2026-11-11 5:54 ` Luca Ceresoli
2026-11-11 6:30 ` Matti Vaittinen
2026-11-10 21:54 ` [PATCH v4 20/20] mfd: Unify style of pci_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-11-10 22:01 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-207802@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=lee@kernel.org \
--cc=mfd@lists.linux.dev \
--cc=sashiko-reviews@lists.linux.dev \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).