From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 801102C88 for ; Thu, 21 Oct 2021 10:03:09 +0000 (UTC) Received: by mail-pj1-f47.google.com with SMTP id na16-20020a17090b4c1000b0019f5bb661f9so197542pjb.0 for ; Thu, 21 Oct 2021 03:03:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=dyIzNS94yVFn26I1+Vs+X45Vc6HJjjNBIVAQhUczpSM=; b=VWDF7tT1/ERaiy+hd0f6TMm9xFOihJIvjzaya/s3ODTaGnjpSPJdbYprA4nNTrVcbD bGlCes4+wktbJ3qFkdxKX+pF3DSJZ3pwm1T+rFQES8zBRpNnOrXkgKXHJ2bue3r3p4G+ H69wUbUsY4TqDGOuFqhQvBvO6pAo8G6ZO6CEnUPDxxUOz6DdGTmalk5Q68ba/STSUsLs cds7OJH3l3frdAhraIIVaAAqHEX+fjg63+fTS/Iv2xbAF5DLtfQp8/2JJG6vSVgCrzCp biMIQFzCz+kKkNEb+g8wP/QnInQP1CRNTU7ldpMMsO8ZEgAaQcc58to35Vlx9L2XWw8h b6aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=dyIzNS94yVFn26I1+Vs+X45Vc6HJjjNBIVAQhUczpSM=; b=jucj0VilVy+WEj1DK0l4ckVlKmh2NTkNiejMCjMf6ny9h5f6wgauJweczzyO3jTGQT 13z7hYVIh9iPxXRs7HtW2i1ZWDVab/Zz1lwd2snbJ2Mt19mcTJBrJ1XZPPi2wT2Vhy0F 5tuNMyrwS7CmzT+Cf0E0J8BaCoweJsZfKq8wj3lEJmz2BRq+5d5JdoH2/h8XAsr0m7WE Wbwff5zhojitHDILvaVx52TbI2g1rnf0GBfwG4hMHAbo4Josk2QpjELbXUMumJVs01T8 fLsXbY8Nqp0TFay4zyRCH76P+xpWGuFB9XOAUGoRSPXLoj8KslM2LUBZ8WYpnIxsTiVO 2veQ== X-Gm-Message-State: AOAM531XHkP1Tf5KK+4H45fOJOjGGNQzjil/rg6CDbvmA4GiCfgdpiSS pntaJMcOrHzIqrb3Z0IEu1aK X-Google-Smtp-Source: ABdhPJzzDD1MByFwNyBzIySK4PYWZmbpJVSVMenRc0Dxbbe1gHD8Vc4vuRM4kZ/i3/h7/Lf0nSzXIA== X-Received: by 2002:a17:90b:1196:: with SMTP id gk22mr5654164pjb.126.1634810589002; Thu, 21 Oct 2021 03:03:09 -0700 (PDT) Received: from workstation ([202.21.43.20]) by smtp.gmail.com with ESMTPSA id f33sm8717545pjk.42.2021.10.21.03.03.06 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Oct 2021 03:03:08 -0700 (PDT) Date: Thu, 21 Oct 2021 15:33:05 +0530 From: Manivannan Sadhasivam To: Kalle Valo Cc: Loic Poulain , ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-arm-msm , regressions@lists.linux.dev, mhi Subject: Re: [regression] mhi: ath11k resume fails on some devices Message-ID: <20211021100305.GD7580@workstation> References: <871r5p0x2u.fsf@codeaurora.org> <877df6tlnq.fsf@codeaurora.org> <87a6jl9ndo.fsf@codeaurora.org> <87ee8hgqni.fsf@codeaurora.org> Precedence: bulk X-Mailing-List: mhi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87ee8hgqni.fsf@codeaurora.org> User-Agent: Mutt/1.9.4 (2018-02-28) On Tue, Oct 19, 2021 at 03:12:01PM +0300, Kalle Valo wrote: > Kalle Valo writes: > > > (adding the new mhi list, yay) > > > > Hi Loic, > > > > Loic Poulain writes: > > > >>> Loic Poulain writes: > >>> > >>> > On Thu, 16 Sept 2021 at 10:00, Kalle Valo wrote: > >>> > >>> >> At the moment I'm running my tests with commit 020d3b26c07a reverted and > >>> >> everything works without problems. Is there a simple way to fix this? Or > >>> >> maybe we should just revert the commit? Commit log and kernel logs from > >>> >> a failing case below. > >>> > > >>> > Do you have log of success case? > >>> > >>> A log from a successful case in the end of email, using v5.15-rc1 plus > >>> revert of commit 020d3b26c07abe27. > >>> > >>> > To me, the device loses power, that is why MHI resuming is failing. > >>> > Normally the device should be properly recovered/reinitialized. Before > >>> > that patch the power loss was simply not detected (or handled at > >>> > higher stack level). > >>> > >>> Currently in ath11k we always keep the firmware running when in suspend, > >>> this is a workaround due to problems between mac80211 and MHI stack. > >>> IIRC the problem was something related MHI creating struct device during > >>> resume or something like that. > >> > >> Could you give a try with the attached patch? It should solve your > >> issue without breaking modem support. > > > > Sorry for taking so long, but I now tested your patch on top of > > v5.15-rc3 and, as expected, everything works as before with QCA6390 on > > NUC x86 testbox. > > > > Tested-by: Kalle Valo > > I doubt we will find enough time to fully debug this mhi issue anytime > soon. Can we commit Loic's patch so that this regression is resolved? > Sorry no :( Eventhough Loic's patch is working, I want to understand the issue properly so that we could add a proper fix or patch the firmware if possible. Let's try to get the debug logs as I requested. Thanks, Mani > At the moment I'm doing all my regression testing with commit > 020d3b26c07abe27 reverted. That's a risk, I would prefer to do my > testing without any hacks. > > -- > https://patchwork.kernel.org/project/linux-wireless/list/ > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches