From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7030B6E607 for ; Fri, 1 Mar 2024 12:26:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709295968; cv=none; b=FB5rUuz80UiFfyrL4ue6i5EQaHG+b2Klosw9z6eiP8ZH4dm/E+B9s7RExHGOaZRz7mvLVorBu5IP2Q2qBArnAHMOndvtBh7lCQuViSdJpWM53DO+tUjQRXnibTj7FUx1W83ufi/41Ks9ZFsLmqSm3aSqPIv85B7ZDsiNhRseIfY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709295968; c=relaxed/simple; bh=DCxEN7tYRiXh61QyHjoT94wXv3D+5boFGgkhPYQVN4E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=D3QwmAGVvc0QAXIYNw8rixw9l5ayEQxxjhxklDO3BJRck7XxJ0He0YjaCdhXcHtsV0Hf1Gg0SRy7UKFQaEDdQgNtNYRowhi6opwbGIwl+GhSLU3wplSrFzayIDzDVkiiOwnubEOgcKpXid1ovv2ROMLcjOpvRAiYohMlVpvlChA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=VU1UGrlP; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VU1UGrlP" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-5ce942efda5so1624312a12.2 for ; Fri, 01 Mar 2024 04:26:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709295965; x=1709900765; darn=lists.linux.dev; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=n4vy0ssj1y9OKJx6whcKaZP2Wd8dgYFve24tfX8P7n0=; b=VU1UGrlPczIU0Zn9wLVg5TzS2o2T+0ujt74WCzLPloUZWuHqSnKJOZKAT7Wp/HumCf /dHfXRlRtXnfSMWScdjl2WCk9xjBGVZdz+U24vn9lpZ4JhN15X6iZ7FjyrMnRXU7TBVp t+CHWOZJ+adgq1XpjWs8frKSLkg6Tubi3iflke5TFYyghg+SdEN5y/VLngcMKPHQEB71 9fKBHY0TdPhVRKDl4dO6J6e2C7pLLZl8yRwvmYl//0y6WLSSQh3hIWtA7T0TFFKvM6PQ VPadTQFAooMr78SiJRScJ+6BUMGJ9Oy0HZ5g3D+TUlcT6eCi7bM8D2+30enm20OCQsXe 6k4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709295965; x=1709900765; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=n4vy0ssj1y9OKJx6whcKaZP2Wd8dgYFve24tfX8P7n0=; b=DcUJzKBrP2GcvA7jVkQgDexd9g0o6gEXsKRVzeHsNNmz65zRt1Ha/1H1XfCKSpnIY8 EtSahtCPBPIq1LmdOeSledigoVcr+p//sJbwOvWBeF5cp2eEpWMP0LK940zLN8azy/zQ 3O/xoG0OHCpcS6lVdZkZ20xHkRInBMIZri69l3dMb/lpP6KtAuvfFB5bZfgDAKkdD15h rLx5wwa1Mk51iuHhWNguMGHz/i8ce3A6iiriwuH74LqRrSL4unknSPOUotEFgLBl9RkO THhu/tdjYBSwJpQ+v0VZDNGmECsR88WOltKl5UZdzgWvWFa2N/ZDupaMqfYFPoQCSUPr rSIA== X-Forwarded-Encrypted: i=1; AJvYcCX6u9aEaQLoR3a6r2qFZgJwYj5ckbOg6dAF9bzF16MPc1mHu8hurXC2OgtQzB0dVrnr+TICwMPPwqOE7nc3xKwAbhgT X-Gm-Message-State: AOJu0YwucZkBucaitTj/FNljDlI+qjCD2ByFwuVwXvV/YB0foBWAVFLd Daa7BwaT0+vhNPIPED+UIvtRy/nHl+jLhfGWh5DaTeHJyYBAQwl+yPY7CxlJcg== X-Google-Smtp-Source: AGHT+IHDbZOb0MqU0lNgT6Ylu5XAVO9Rkznovko5WeZRWLmmdsVhJISyuzq0BMbPgmlDmT83+wLDug== X-Received: by 2002:a05:6a20:4327:b0:1a0:6856:d12c with SMTP id h39-20020a056a20432700b001a06856d12cmr1584913pzk.18.1709295965331; Fri, 01 Mar 2024 04:26:05 -0800 (PST) Received: from thinkpad ([2409:40f4:13:3cbc:2484:3780:dcff:ebcf]) by smtp.gmail.com with ESMTPSA id p12-20020aa7860c000000b006e50e79f155sm2834437pfn.60.2024.03.01.04.26.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 04:26:04 -0800 (PST) Date: Fri, 1 Mar 2024 17:55:59 +0530 From: Manivannan Sadhasivam To: Baochen Qiang Cc: Kalle Valo , "Kalle Valo (QUIC)" , ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-arm-msm@vger.kernel.org, mhi@lists.linux.dev, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org Subject: Re: [PATCH v4 1/3] bus: mhi: host: add mhi_power_down_keep_dev() Message-ID: <20240301122559.GB2401@thinkpad> References: <20240228022243.17762-1-quic_bqiang@quicinc.com> <20240228022243.17762-2-quic_bqiang@quicinc.com> <20240229101202.GB2999@thinkpad> <531daaa9-cf14-4812-8908-c617bd25bc08@quicinc.com> <87le7383nd.fsf@kernel.org> Precedence: bulk X-Mailing-List: mhi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Mar 01, 2024 at 10:04:06AM +0800, Baochen Qiang wrote: > > > On 3/1/2024 3:35 AM, Kalle Valo wrote: > > Baochen Qiang writes: > > > > > On 2/29/2024 6:12 PM, Manivannan Sadhasivam wrote: > > > > On Wed, Feb 28, 2024 at 10:22:41AM +0800, Baochen Qiang wrote: > > > > > ath11k fails to resume: > > > > > > > > > > ath11k_pci 0000:06:00.0: timeout while waiting for restart complete > > > > > > > > > > This happens because when calling mhi_sync_power_up() the MHI subsystem > > > > > eventually calls device_add() from mhi_create_devices() but the device > > > > > creation is deferred: > > > > > > > > > > mhi mhi0_IPCR: Driver qcom_mhi_qrtr force probe deferral > > > > > > > > > > The reason for deferring device creation is explained in dpm_prepare(): > > > > > > > > > > /* > > > > > * It is unsafe if probing of devices will happen during suspend or > > > > > * hibernation and system behavior will be unpredictable in this case. > > > > > * So, let's prohibit device's probing here and defer their probes > > > > > * instead. The normal behavior will be restored in dpm_complete(). > > > > > */ > > > > > > > > > > Because the device probe is deferred, the qcom_mhi_qrtr_probe() is not > > > > > called and thus MHI channels are not prepared: > > > > > > > > > > So what this means that QRTR is not delivering messages and the QMI connection > > > > > is not working between ath11k and the firmware, resulting a failure in firmware > > > > > initialization. > > > > > > > > > > To fix this add new function mhi_power_down_keep_dev() which doesn't destroy > > > > > the devices for channels during power down. This way we avoid probe defer issue > > > > > and finally can get ath11k hibernation working with the following patches. > > > > > > > > > > Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.30 > > > > > > > > > > Signed-off-by: Kalle Valo > > > > > > > > Did Kalle co-author this patch? If so, his Co-developed-by tag should > > > > be added. > > > > > > Hmm, I'm not sure... I would like Kalle's thoughts on this. > > > > IIRC I did only some simple cleanup before submitting the patch so I > > don't think Co-developed-by is justified. I'm also fine with removing my > > Signed-off-by. > Thanks Kalle. > > Hi Mani, so according to Kalle's comments, I'd like to keep the patch as is. > No. Either remove his signed off by (as indicated by Kalle) or add a co-developed-by tag. Keeping just a signed-off-by tag is wrong. - Mani -- மணிவண்ணன் சதாசிவம்