From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Vivek Pernamitta <quic_vpernami@quicinc.com>
Cc: mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bus: mhi: host: Enable MSIx if the endpoint supports
Date: Mon, 6 Jan 2025 20:21:59 +0530 [thread overview]
Message-ID: <20250106145159.oqseq7ysedmrmyey@thinkpad> (raw)
In-Reply-To: <20250106-msix-v1-1-91d7b7143118@quicinc.com>
On Mon, Jan 06, 2025 at 10:17:33AM +0530, Vivek Pernamitta wrote:
> Enable MSIx if the end point supports.
>
s/MSIx/MSI-X
s/end point/endpoint
> Signed-off-by: Vivek Pernamitta <quic_vpernami@quicinc.com>
> ---
> Enable MSIx if the endpoint supports.
No need of the comment here.
Change LGTM!
- Mani
> ---
> drivers/bus/mhi/host/pci_generic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> index 56ba4192c89c16b4882d2e7c95f0dc689fd1e267..af1380220904a7e6232ff1b374da0a4ea49cb470 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -949,7 +949,7 @@ static int mhi_pci_get_irqs(struct mhi_controller *mhi_cntrl,
> */
> mhi_cntrl->nr_irqs = 1 + mhi_cntrl_config->num_events;
>
> - nr_vectors = pci_alloc_irq_vectors(pdev, 1, mhi_cntrl->nr_irqs, PCI_IRQ_MSI);
> + nr_vectors = pci_alloc_irq_vectors(pdev, 1, mhi_cntrl->nr_irqs, PCI_IRQ_MSIX | PCI_IRQ_MSI);
> if (nr_vectors < 0) {
> dev_err(&pdev->dev, "Error allocating MSI vectors %d\n",
> nr_vectors);
>
> ---
> base-commit: 8155b4ef3466f0e289e8fcc9e6e62f3f4dceeac2
> change-id: 20250106-msix-a4c5488ecafe
>
> Best regards,
> --
> Vivek Pernamitta <quic_vpernami@quicinc.com>
>
--
மணிவண்ணன் சதாசிவம்
prev parent reply other threads:[~2025-01-06 14:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-06 4:47 [PATCH] bus: mhi: host: Enable MSIx if the endpoint supports Vivek Pernamitta
2025-01-06 14:51 ` Manivannan Sadhasivam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250106145159.oqseq7ysedmrmyey@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhi@lists.linux.dev \
--cc=quic_vpernami@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox