From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68231199230; Tue, 9 Dec 2025 06:38:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765262298; cv=none; b=JHWv3Fhn5LErpq3vhZRypGj0Pu7gh9csYhlNxRAFWkRrQlEKwRUaWqp9NYOb0hBsDDcmp+2+dxCdXssBiZFQbnFUmlji8y1BH7OF1cZUrsRlFP56d5H+LYEJx8zc8r4N9+tBfGK5Rj4FYfJMWPvYDuFjpAMPABS1HhgLxhHLPF4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765262298; c=relaxed/simple; bh=xzM56ImHaGqlS44dVuPIX6ZJ/sTggxw7Eb2KfxoA8rE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=C4/EWMjTImznyOzSsFJR5lmc6JigK+apsihdFDPvNC9IOsfEssoR6e47Dq3h3rjMtKNo10WNrHe0jTpnUbTIFffx20T2N3PdnEYqP5jXvXr4sWWS62KVPVSpkiWbpTwItwQmeIAyQdSyEhTedUT0bjpnE37Jg+9swhSGSmxWYdo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 1062568AFE; Tue, 9 Dec 2025 07:38:09 +0100 (CET) Date: Tue, 9 Dec 2025 07:38:09 +0100 From: Christoph Hellwig To: Frank Li Cc: Vinod Koul , Manivannan Sadhasivam , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Kishon Vijay Abraham I , Bjorn Helgaas , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni , Herbert Xu , "David S. Miller" , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Koichiro Den , Niklas Cassel , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-nvme@lists.infradead.org, mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev Subject: Re: [PATCH 1/8] dmaengine: Add API to combine configuration and preparation (sg and single) Message-ID: <20251209063809.GA27728@lst.de> References: <20251208-dma_prep_config-v1-0-53490c5e1e2a@nxp.com> <20251208-dma_prep_config-v1-1-53490c5e1e2a@nxp.com> Precedence: bulk X-Mailing-List: mhi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251208-dma_prep_config-v1-1-53490c5e1e2a@nxp.com> User-Agent: Mutt/1.5.17 (2007-11-01) On Mon, Dec 08, 2025 at 12:09:40PM -0500, Frank Li wrote: > Previously, configuration and preparation required two separate calls. This > works well when configuration is done only once during initialization. > > However, in cases where the burst length or source/destination address must > be adjusted for each transfer, calling two functions is verbose and > requires additional locking to ensure both steps complete atomically. > > Add a new API and callback device_prep_slave_sg_config that combines > configuration and preparation into a single operation. If the configuration > argument is passed as NULL, fall back to the existing implementation. Maybe this would be a good time to start retiring the "slave" naming and come up with shorter names as a win-win situation?