public inbox for mhi@lists.linux.dev
 help / color / mirror / Atom feed
From: Alexander Wilhelm <alexander.wilhelm@westermo.com>
To: Jeff Hugo <jeff.hugo@oss.qualcomm.com>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] bus: mhi: host: fix endianness of BHI vector table
Date: Mon, 19 May 2025 16:48:20 +0200	[thread overview]
Message-ID: <aCtEtASIl8oQPNBc@FUE-ALEWI-WINX> (raw)
In-Reply-To: <cf4adaba-5601-40b9-bd17-1b1bfa686b0f@oss.qualcomm.com>

Am Mon, May 19, 2025 at 08:13:00AM -0600 schrieb Jeff Hugo:
> On 5/19/2025 12:10 AM, Alexander Wilhelm wrote:
> > On big endian platform like PowerPC the MHI bus does not start properly. The
> > following example shows the error messages by using qcn9274 wireless radio
> > module with ath12k driver:
> > 
> >      ath12k_pci 0001:01:00.0: BAR 0: assigned [mem 0xc00000000-0xc001fffff 64bit]
> >      ath12k_pci 0001:01:00.0: MSI vectors: 1
> >      ath12k_pci 0001:01:00.0: Hardware name: qcn9274 hw2.0
> >      ath12k_pci 0001:01:00.0: failed to set mhi state: POWER_ON(2)
> >      ath12k_pci 0001:01:00.0: failed to start mhi: -110
> >      ath12k_pci 0001:01:00.0: failed to power up :-110
> >      ath12k_pci 0001:01:00.0: failed to create soc core: -110
> >      ath12k_pci 0001:01:00.0: failed to init core: -110
> >      ath12k_pci: probe of 0001:01:00.0 failed with error -110
> > 
> > Fix it by swapping DMA address and size of the BHI vector table.
> > 
> > Signed-off-by: Alexander Wilhelm <alexander.wilhelm@westermo.com>
> > Reviewed-by: Jeff Hugo <jeff.hugo@oss.qualcomm.com>
> 
> Shouldn't there be a fixes tag?  Probably pointing to one of the original
> MHI commits given what this change is touching.
> 
> -Jeff

Thank you for supporting me. I will add that in the next patch version. This
patch fixes 3 different origin commits. I would take the first one, where
bhi_vec_entry was first introducted. The following 2 commits are only follow up
errors.

Best regards
Alexander Wilhelm

      reply	other threads:[~2025-05-19 14:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-19  6:10 [PATCH v3] bus: mhi: host: fix endianness of BHI vector table Alexander Wilhelm
2025-05-19 14:13 ` Jeff Hugo
2025-05-19 14:48   ` Alexander Wilhelm [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aCtEtASIl8oQPNBc@FUE-ALEWI-WINX \
    --to=alexander.wilhelm@westermo.com \
    --cc=jeff.hugo@oss.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=mhi@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox