From: Moritz Wilhelmy <ml+mmj@wzff.de>
To: mlmmj@mlmmj.org
Subject: [mlmmj] hardcoded delimiter in mlmmj-process.c?
Date: Sat, 12 Mar 2011 00:04:56 +0000 [thread overview]
Message-ID: <20110312000456.GM24920@barfooze.de> (raw)
Dear list,
Today, I found some references to listname-moderators@listdomain by
accident, but the delimiter is +.
From mlmmj-1.2.17.1/src/mlmmj-process.c:127 (139 in tip), it seems this
is hardcoded to -:
> to = concatstr(3, listname, "-moderators@", listfqdn); /* FIXME JFA: Should this be converted? Why, why not? */
This baffled me a bit. It says FIXME, but not what is subject to be
fixed. Assuming that the FIXME is about the minus, I don't see why it
should *not* be changed to use the same delimiter that's used everywhere
else...
Best regards,
Moritz
next reply other threads:[~2011-03-12 0:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-12 0:04 Moritz Wilhelmy [this message]
2011-03-12 3:43 ` [mlmmj] hardcoded delimiter in mlmmj-process.c? Ben Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110312000456.GM24920@barfooze.de \
--to=ml+mmj@wzff.de \
--cc=mlmmj@mlmmj.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox