From: Thomas Goirand <thomas@goirand.fr>
To: mlmmj@mlmmj.org
Subject: [mlmmj] [patch] Remove bashism from src/mlmmj-make-ml.sh.in
Date: Sun, 22 Jan 2012 07:52:20 +0000 [thread overview]
Message-ID: <4F1BC034.5060304@goirand.fr> (raw)
[-- Attachment #1: Type: text/plain, Size: 446 bytes --]
Hi,
src/mlmmj-make-ml.sh.in declares it uses sh and not bash, but it has
bashism which may fail if dash is the default implementation for sh
(which is the case now in both Debian and Ubuntu).
Please apply the attached patch which removes bashism in
src/mlmmj-make-ml.sh.in. I've been carrying this patch for too long, and
I'd like to have it removed from the debian/patches folder for the next
release of MLMMJ.
Thanks,
Thomas Goirand (zigo)
[-- Attachment #2: 06_fix_bashisms_mlmmj-make-ml.diff --]
[-- Type: text/x-diff, Size: 598 bytes --]
From: <dan@icarus.sumodave.com>
Subject: Remove bashisms from make-mlmmj-ml script.
Forwarded: no
diff -urNad a/src/mlmmj-make-ml.sh.in b/src/mlmmj-make-ml.sh.in
--- a/src/mlmmj-make-ml.sh.in 2008-10-30 21:01:13.000000000 +0000
+++ b/src/mlmmj-make-ml.sh.in 2010-01-04 20:44:42.000000000 +0000
@@ -21,7 +21,7 @@
do
case "$Option" in
h )
- echo -e "$USAGE"
+ echo "$USAGE"
exit 0
;;
z )
@@ -42,7 +42,8 @@
CHOWN="$OPTARG"
;;
* )
- echo -e "$0: invalid option\nTry $0 -h for more information."
+ echo "$0: invalid option"
+ echo "Try $0 -h for more information."
exit 1
esac
done
next reply other threads:[~2012-01-22 7:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-22 7:52 Thomas Goirand [this message]
2012-01-22 12:23 ` [mlmmj] [patch] Remove bashism from src/mlmmj-make-ml.sh.in Mark Alan
2012-01-22 13:27 ` Ben Schmidt
2012-01-22 13:36 ` Yuri D'Elia
2012-01-22 18:56 ` Thomas Goirand
2012-01-23 0:18 ` Ben Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F1BC034.5060304@goirand.fr \
--to=thomas@goirand.fr \
--cc=mlmmj@mlmmj.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox