From: Ben Schmidt <mail_ben_schmidt@yahoo.com.au>
To: mlmmj@mlmmj.org
Subject: Re: [mlmmj] [patch] Remove bashism from src/mlmmj-make-ml.sh.in
Date: Mon, 23 Jan 2012 00:18:57 +0000 [thread overview]
Message-ID: <4F1CA771.70909@yahoo.com.au> (raw)
In-Reply-To: <4F1BC034.5060304@goirand.fr>
>>> Better yet, use a single command:
>>> - echo -e "$0: invalid option\nTry $0 -h for more information."
>>> + printf "$0: invalid option\nTry $0 -h for more information.\n"
>>
>> Are you sure this is sh compatible?
>
> The Debian "checkbashisms" script doesn't report any error with it.
Thanks to you and everyone else who confirmed this for me. It is greatly
appreciated.
>> I wonder if the echo version is perhaps more readable, and thus
>> preferable anyway, rather than single-command wizardry. What do you
>> think?
>
> I agree.
I think the majority has this view.
I'm pushing the change out now.
Ben.
prev parent reply other threads:[~2012-01-23 0:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-22 7:52 [mlmmj] [patch] Remove bashism from src/mlmmj-make-ml.sh.in Thomas Goirand
2012-01-22 12:23 ` Mark Alan
2012-01-22 13:27 ` Ben Schmidt
2012-01-22 13:36 ` Yuri D'Elia
2012-01-22 18:56 ` Thomas Goirand
2012-01-23 0:18 ` Ben Schmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F1CA771.70909@yahoo.com.au \
--to=mail_ben_schmidt@yahoo.com.au \
--cc=mlmmj@mlmmj.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox