[mlmmj] access::Deny seems to have stopped working ?

[mlmmj] access::Deny seems to have stopped working ?

[Per Jessen]

For years we have had a standard set of access rules, the previous list
manager at openSUSE set them up.  Somehow those rules seems to have
stopped working - example:

deny ^Content-Type:.*image/png

simply does not deny a mail with a png attached.  I was just wondering
if anybody else had observed this? 

We're on mlmmj 1.2.19. 


thanks
Per

-- 
Per Jessen, Zürich (18.2°C)
Member, openSUSE Heroes

Re: [mlmmj] access::Deny seems to have stopped working ?

[Mads Martin Jørgensen]

Have you checked the source of mails going through that it actually matches?

Maybe with. Hex editor. 

> On 14 Jun 2020, at 16.19, Per Jessen <per@opensuse.org> wrote:
> 
> For years we have had a standard set of access rules, the previous list
> manager at openSUSE set them up.  Somehow those rules seems to have
> stopped working - example:
> 
> deny ^Content-Type:.*image/png
> 
> simply does not deny a mail with a png attached.  I was just wondering
> if anybody else had observed this? 
> 
> We're on mlmmj 1.2.19. 
> 
> 
> thanks
> Per
> 
> -- 
> Per Jessen, Zürich (18.2°C)
> Member, openSUSE Heroes
> 
> 
> 

Re: [mlmmj] access::Deny seems to have stopped working ?

[Per Jessen]

Mads Martin Jørgensen wrote:
> Have you checked the source of mails going through that it actually matches?
> 
> Maybe with. Hex editor. 

Oh yes, it matches just fine.  That's the weird thing.  I've tested with 
standard emails from Thunderbird.  Other people have noticed the same because we 
suddenly had emails with e.g. pngs turning up on our mailing lists.



brgds
Per


-- 
Per Jessen, Zürich (17.7°C)
Member, openSUSE Heroes

Re: [mlmmj] access::Deny seems to have stopped working ?

[Per Jessen]

Per Jessen wrote:

> For years we have had a standard set of access rules, the previous
> list manager at openSUSE set them up.  Somehow those rules seems to
> have stopped working - example:
> 
> deny ^Content-Type:.*image/png
> 
> simply does not deny a mail with a png attached.  I was just wondering
> if anybody else had observed this?

This morning I added some debug output to mlmmj-process - the reason
the "deny" above isn't working is simply that MIME headers in the email
body are not being tested :-) 

I guess our many 'deny' rules (to refuse various attachments) quite
simply _never_ worked. 


-- 
Per Jessen, Zürich (17.4°C)
Member, openSUSE Heroes

Re: [mlmmj] access::Deny seems to have stopped working ?

[Roderick]

On Tue, 16 Jun 2020, Per Jessen wrote:

> This morning I added some debug output to mlmmj-process - the reason
> the "deny" above isn't working is simply that MIME headers in the email
> body are not being tested :-)
>
> I guess our many 'deny' rules (to refuse various attachments) quite
> simply _never_ worked.

Is that really the case? Is there the functionality to test the body
of a mail, here MIME headers of an attachment? I read in
README.access only:

"""
Each header in the mail is tested against each rule, rule by rule.
That is, all headers are first tested against the first rule, then
all headers are tested against the second rule, and so on.
""""

Rodrigo

Re: [mlmmj] access::Deny seems to have stopped working ?

[Per Jessen]

Roderick wrote:

> On Tue, 16 Jun 2020, Per Jessen wrote:
> 
>> This morning I added some debug output to mlmmj-process - the reason
>> the "deny" above isn't working is simply that MIME headers in the email
>> body are not being tested :-)
>>
>> I guess our many 'deny' rules (to refuse various attachments) quite
>> simply _never_ worked.
> 
> Is that really the case? 

As far as I can tell from the source code and my debugging, yes - headers are 
only collected until the empty line between header and body.

I don't know if there is any other way.


-- 
Per Jessen, Zürich (19.2°C)
Member, openSUSE Heroes

Re: [mlmmj] access::Deny seems to have stopped working ?

[Mads Martin Jørgensen]

That's because it's kind of headers, in the body. IIRC you're right Per. Only headers are checked.

> On 16 Jun 2020, at 11.19, Per Jessen <per@opensuse.org> wrote:
> 
> As far as I can tell from the source code and my debugging, yes - headers are only collected until the empty line between header and body.

-- 
Mads Martin Jørgensen
“Why make things difficult, when it is possible to make them cryptic and totally illogical, with just a little bit more effort?” - A. P. J

Re: [mlmmj] access::Deny seems to have stopped working ?

[Roderick]

On Tue, 16 Jun 2020, Per Jessen wrote:

> As far as I can tell from the source code and my debugging, yes - headers are 
> only collected until the empty line between header and body.

And that corresponds to what I read in README.access. That is what I
wanted to say: no bug. The OP expects a feature neither implemented
nor documented: to filter according to contents in the body. For
trateing headers in attachments with RE one needs perhaps something
like a variable in it with the boundary.

Rodrigo

Re: [mlmmj] access::Deny seems to have stopped working ?

[Per Jessen]

Mads Martin Jørgensen wrote:

> That's because it's kind of headers, in the body. IIRC you're right
> Per. Only headers are checked.
> 

Thanks for confirming it, Mads.




-- 
Per Jessen, Zürich (19.2°C)
Member, openSUSE Heroes

Re: [mlmmj] access::Deny seems to have stopped working ?

[Per Jessen]

Roderick wrote:

> On Tue, 16 Jun 2020, Per Jessen wrote:
> 
>> As far as I can tell from the source code and my debugging, yes -
>> headers are only collected until the empty line between header and
>> body.
> 
> And that corresponds to what I read in README.access. That is what I
> wanted to say: no bug. 

Oh yes, I agree.  If anything, the bug is on our side, that we have
expected it to work for more than 13 years :-) 


-- 
Per Jessen, Zürich (19.1°C)
Member, openSUSE Heroes