From: Richard Mortimer <richm@oldelvet.org.uk>
To: mlmmj@mlmmj.org
Subject: [mlmmj] [PATCH 00 of 10] mlmmj-maintd.c tweaks
Date: Thu, 27 Jan 2011 22:59:18 +0000 [thread overview]
Message-ID: <patchbomb.1296169158@duncow> (raw)
All,
As mentioned the other day here are a number of patches against
mlmmj-maintd.c that fix relatively minor issues. I haven't attempted
to make any changes outside of this one file but intend to look at those
over the coming month or two as time allows.
I have also spotted a couple of other issues that I haven't addressed yet.
The first is the fact that unlink calls never have their error status
checked. I was thinking about introducing a myunlink() method that does
the unlink and reports any error. That would help catch any permissions
problems. There is a potential that some of the files might not exist
in all situations (the -probe files for example) so it might not be
appropriate to log an error in all circumstances.
Also there are a couple of places in mlmmj-maintd.c where it doesn't find
the contents of the files that it expects. It just carries onto the next
file without logging an error.
Review comments most welcome.
Regards
Richard
next reply other threads:[~2011-01-27 22:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-27 22:59 Richard Mortimer [this message]
2011-01-28 17:24 ` [mlmmj] [PATCH 00 of 10] mlmmj-maintd.c tweaks Ben Schmidt
2012-01-17 14:08 ` Ben Schmidt
2012-01-17 18:06 ` Richard Mortimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=patchbomb.1296169158@duncow \
--to=richm@oldelvet.org.uk \
--cc=mlmmj@mlmmj.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox