From: akpm@linux-foundation.org
To: mm-commits@vger.kernel.org
Cc: hector.palacios@digi.com, dbrownell@users.sourceforge.net,
grant.likely@secretlab.ca
Subject: + spi-spidev_test-gives-error-upon-1-byte-transfer.patch added to -mm tree
Date: Thu, 29 Apr 2010 15:02:28 -0700 [thread overview]
Message-ID: <201004292202.o3TM2TZv014295@imap1.linux-foundation.org> (raw)
The patch titled
spi: spidev_test gives error upon 1-byte transfer
has been added to the -mm tree. Its filename is
spi-spidev_test-gives-error-upon-1-byte-transfer.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: spi: spidev_test gives error upon 1-byte transfer
From: Hector Palacios <hector.palacios@digi.com>
The sample application spidev_test.c is using SPI_IOC_MESSAGE ioctl to do
an SPI transfer. This ioctl returns the number of bytes successfully
transmitted or a negative error code upon erroneous completion. The
application however is returning an error if the result of the ioclt if
the return value is 1. This makes the application to fail upon 1-byte
length transfers.
Signed-off-by: Hector Palacios <hector.palacios@digi.com>
Cc: David Brownell <dbrownell@users.sourceforge.net>
Cc: Grant Likely <grant.likely@secretlab.ca>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
Documentation/spi/spidev_test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN Documentation/spi/spidev_test.c~spi-spidev_test-gives-error-upon-1-byte-transfer Documentation/spi/spidev_test.c
--- a/Documentation/spi/spidev_test.c~spi-spidev_test-gives-error-upon-1-byte-transfer
+++ a/Documentation/spi/spidev_test.c
@@ -58,7 +58,7 @@ static void transfer(int fd)
};
ret = ioctl(fd, SPI_IOC_MESSAGE(1), &tr);
- if (ret == 1)
+ if (ret < 1)
pabort("can't send spi message");
for (ret = 0; ret < ARRAY_SIZE(tx); ret++) {
_
Patches currently in -mm which might be from hector.palacios@digi.com are
spi-spidev_test-gives-error-upon-1-byte-transfer.patch
reply other threads:[~2010-04-30 17:09 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201004292202.o3TM2TZv014295@imap1.linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dbrownell@users.sourceforge.net \
--cc=grant.likely@secretlab.ca \
--cc=hector.palacios@digi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox