From mboxrd@z Thu Jan 1 00:00:00 1970 From: akpm@linux-foundation.org Subject: + toshiba_acpi-make-remove_device-and-add_device-void.patch added to -mm tree Date: Thu, 08 Jul 2010 14:38:58 -0700 Message-ID: <201007082138.o68LcwHB030587@imap1.linux-foundation.org> Reply-To: linux-kernel@vger.kernel.org Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:46149 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753238Ab0GHVkK (ORCPT ); Thu, 8 Jul 2010 17:40:10 -0400 Sender: mm-commits-owner@vger.kernel.org List-Id: mm-commits@vger.kernel.org To: mm-commits@vger.kernel.org Cc: axel.lin@gmail.com, mjg@redhat.com, nm127@freemail.hu The patch titled toshiba_acpi: make remove_device() and add_device() void has been added to the -mm tree. Its filename is toshiba_acpi-make-remove_device-and-add_device-void.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your cod= e *** See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mm= otm/ ------------------------------------------------------ Subject: toshiba_acpi: make remove_device() and add_device() void =46rom: Axel Lin remove_device() and add_device() are not related to ACPI APIs, it does = not make sense to return acpi_status for both functions. Current implementation of add_device() always AE_OK, thus the return va= lue checking for add_device() always return false for ACPI_FAILURE(status).= =20 This patch makes add_device() to be void and remove the unnecessary ret= urn value checking. remove_proc_entry() won't fail, thus change remove_device() to be void. Signed-off-by: Axel Lin Cc: Matthew Garrett Cc: M=E1rton N=E9meth Signed-off-by: Andrew Morton --- drivers/platform/x86/toshiba_acpi.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff -puN drivers/platform/x86/toshiba_acpi.c~toshiba_acpi-make-remove_= device-and-add_device-void drivers/platform/x86/toshiba_acpi.c --- a/drivers/platform/x86/toshiba_acpi.c~toshiba_acpi-make-remove_devi= ce-and-add_device-void +++ a/drivers/platform/x86/toshiba_acpi.c @@ -720,25 +720,22 @@ static const struct file_operations vers =20 #define PROC_TOSHIBA "toshiba" =20 -static acpi_status __init add_device(void) +static void __init add_device(void) { proc_create("lcd", S_IRUGO | S_IWUSR, toshiba_proc_dir, &lcd_proc_fop= s); proc_create("video", S_IRUGO | S_IWUSR, toshiba_proc_dir, &video_proc= _fops); proc_create("fan", S_IRUGO | S_IWUSR, toshiba_proc_dir, &fan_proc_fop= s); proc_create("keys", S_IRUGO | S_IWUSR, toshiba_proc_dir, &keys_proc_f= ops); proc_create("version", S_IRUGO, toshiba_proc_dir, &version_proc_fops)= ; - - return AE_OK; } =20 -static acpi_status remove_device(void) +static void remove_device(void) { remove_proc_entry("lcd", toshiba_proc_dir); remove_proc_entry("video", toshiba_proc_dir); remove_proc_entry("fan", toshiba_proc_dir); remove_proc_entry("keys", toshiba_proc_dir); remove_proc_entry("version", toshiba_proc_dir); - return AE_OK; } =20 static struct backlight_ops toshiba_backlight_data =3D { @@ -921,7 +918,6 @@ static void toshiba_acpi_exit(void) =20 static int __init toshiba_acpi_init(void) { - acpi_status status =3D AE_OK; u32 hci_result; bool bt_present; int ret =3D 0; @@ -969,11 +965,7 @@ static int __init toshiba_acpi_init(void toshiba_acpi_exit(); return -ENODEV; } else { - status =3D add_device(); - if (ACPI_FAILURE(status)) { - toshiba_acpi_exit(); - return -ENODEV; - } + add_device(); } =20 props.max_brightness =3D HCI_LCD_BRIGHTNESS_LEVELS - 1; _ Patches currently in -mm which might be from axel.lin@gmail.com are linux-next.patch hp-wmi-return-enodev-if-bios-does-not-export-any-supported-hp-wmi-guid.= patch fujitsu-laptop-remove-unnecessary-input_free_device-calls.patch compal-laptop-fujitsu-laptop-msi-laptop-make-dmi_check_cb-to-return-1-i= nstead-of-0.patch asus_acpi-fix-a-memory-leak-in-asus_hotk_get_info.patch asus_acpi-fix-coding-style-to-improve-readability.patch acerhdf-make-needlessly-global-symbols-static.patch classmate-laptop-make-needlessly-global-symbols-static.patch fujitsu-laptop-make-needlessly-global-symbols-static.patch msi-laptop-make-struct-rfkill_ops-const.patch asus-laptop-fix-incorrect-return-value-for-write_acpi_int_ret-if-handle= -is-null.patch asus-laptop-return-proper-error-for-store_ledd-if-write_acpi_int-fail.p= atch acerhdf-fix-resource-reclaim-in-error-path.patch toshiba_acpi-make-remove_device-and-add_device-void.patch toshiba_acpi-rename-add_device-and-remove_device-to-create_toshiba_proc= _entries-and-remove_toshiba_proc_entries.patch intel_menlow-fix-memory-leaks-in-error-path-fix.patch drivers-video-backlight-s6e63m0c-set-permissions-on-gamma_table-file-to= -0444.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html