Linux MM tree latest commits
 help / color / mirror / Atom feed
From: akpm@linux-foundation.org
To: mm-commits@vger.kernel.org
Cc: yanmin_zhang@linux.intel.com, andi@firstfloor.org,
	oleg@redhat.com, rientjes@google.com, roland@redhat.com,
	stable@kernel.org
Subject: + ptrace-dont-run-write_locktasklist_lock-if-the-parent-doesnt-ptrace-other-processes.patch added to -mm tree
Date: Wed, 21 Jul 2010 14:49:50 -0700	[thread overview]
Message-ID: <201007212149.o6LLnopp017094@imap1.linux-foundation.org> (raw)


The patch titled
     ptrace: don't run write_lock(tasklist_lock) if the parent doesn't ptrace other processes
has been added to the -mm tree.  Its filename is
     ptrace-dont-run-write_locktasklist_lock-if-the-parent-doesnt-ptrace-other-processes.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/SubmitChecklist when testing your code ***

See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this

The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/

------------------------------------------------------
Subject: ptrace: don't run write_lock(tasklist_lock) if the parent doesn't ptrace other processes
From: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>

We run some sub-cases (fork, exec, pipe, tcp, udp) of aim7 on 8-socket
machine.  Perf shows write_lock_irq(&tasklist_lock) consumes more than 50%
cpu time.

One hot caller is exit_ptrace.  If the exiting process doesn't ptrace
other processes, kernel needn't apply for the write lock on tasklist_lock.

With this patch against kernel 2.6.35-rc5, we get more than 10% result
improvement.

Signed-off-by: Zhang Yanmin <yanmin_zhang@linux.intel.com>
Acked-by: David Rientjes <rientjes@google.com>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Roland McGrath <roland@redhat.com>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 kernel/ptrace.c |    3 +++
 1 file changed, 3 insertions(+)

diff -puN kernel/ptrace.c~ptrace-dont-run-write_locktasklist_lock-if-the-parent-doesnt-ptrace-other-processes kernel/ptrace.c
--- a/kernel/ptrace.c~ptrace-dont-run-write_locktasklist_lock-if-the-parent-doesnt-ptrace-other-processes
+++ a/kernel/ptrace.c
@@ -331,6 +331,9 @@ void exit_ptrace(struct task_struct *tra
 	struct task_struct *p, *n;
 	LIST_HEAD(ptrace_dead);
 
+	if (list_empty(&tracer->ptraced))
+		return;
+
 	write_lock_irq(&tasklist_lock);
 	list_for_each_entry_safe(p, n, &tracer->ptraced, ptrace_entry) {
 		if (__ptrace_detach(tracer, p))
_

Patches currently in -mm which might be from yanmin_zhang@linux.intel.com are

ptrace-dont-run-write_locktasklist_lock-if-the-parent-doesnt-ptrace-other-processes.patch
linux-next.patch


                 reply	other threads:[~2010-07-21 21:50 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201007212149.o6LLnopp017094@imap1.linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mm-commits@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=rientjes@google.com \
    --cc=roland@redhat.com \
    --cc=stable@kernel.org \
    --cc=yanmin_zhang@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox