From: akpm@linux-foundation.org
To: mm-commits@vger.kernel.org
Cc: shijie8@gmail.com, stable@kernel.org, tj@kernel.org
Subject: + percpu-fix-a-memory-leak-in-pcpu_extend_area_map.patch added to -mm tree
Date: Thu, 26 Aug 2010 15:10:29 -0700 [thread overview]
Message-ID: <201008262210.o7QMAThu017413@imap1.linux-foundation.org> (raw)
The patch titled
percpu: fix a memory leak in pcpu_extend_area_map()
has been added to the -mm tree. Its filename is
percpu-fix-a-memory-leak-in-pcpu_extend_area_map.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: percpu: fix a memory leak in pcpu_extend_area_map()
From: Huang Shijie <shijie8@gmail.com>
The original code did not free the old map. This patch fixes it.
[tj@kernel.org: use @old as memcpy source instead of @chunk->map, and indentation and description update]
Signed-off-by: Huang Shijie <shijie8@gmail.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/percpu.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff -puN mm/percpu.c~percpu-fix-a-memory-leak-in-pcpu_extend_area_map mm/percpu.c
--- a/mm/percpu.c~percpu-fix-a-memory-leak-in-pcpu_extend_area_map
+++ a/mm/percpu.c
@@ -393,7 +393,9 @@ static int pcpu_extend_area_map(struct p
goto out_unlock;
old_size = chunk->map_alloc * sizeof(chunk->map[0]);
- memcpy(new, chunk->map, old_size);
+ old = chunk->map;
+
+ memcpy(new, old, old_size);
chunk->map_alloc = new_alloc;
chunk->map = new;
_
Patches currently in -mm which might be from shijie8@gmail.com are
percpu-fix-a-memory-leak-in-pcpu_extend_area_map.patch
kernel-resourcec-handle-reinsertion-of-an-already-inserted-resource.patch
reply other threads:[~2010-08-26 22:11 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201008262210.o7QMAThu017413@imap1.linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=shijie8@gmail.com \
--cc=stable@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox