From mboxrd@z Thu Jan 1 00:00:00 1970 From: akpm@linux-foundation.org Subject: + drivers-char-amiserialc-prevent-reading-uninitialized-stack-memory.patch added to -mm tree Date: Thu, 16 Sep 2010 14:02:43 -0700 Message-ID: <201009162102.o8GL2hOw013426@imap1.linux-foundation.org> Reply-To: linux-kernel@vger.kernel.org Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:50363 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754037Ab0IPVDW (ORCPT ); Thu, 16 Sep 2010 17:03:22 -0400 Sender: mm-commits-owner@vger.kernel.org List-Id: mm-commits@vger.kernel.org To: mm-commits@vger.kernel.org Cc: drosenberg@vsecurity.com, alan@lxorguk.ukuu.org.uk, dan.j.rosenberg@gmail.com, greg@kroah.com The patch titled drivers/char/amiserial.c: prevent reading uninitialized stack memory has been added to the -mm tree. Its filename is drivers-char-amiserialc-prevent-reading-uninitialized-stack-memory.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: drivers/char/amiserial.c: prevent reading uninitialized stack memory From: Dan Rosenberg The TIOCGICOUNT device ioctl allows unprivileged users to read uninitialized stack memory, because the "reserved" member of the serial_icounter_struct struct declared on the stack is not altered or zeroed before being copied back to the user. This patch takes care of it. Signed-off-by: Dan Rosenberg Cc: Alan Cox Cc: Greg KH Signed-off-by: Andrew Morton --- drivers/char/amiserial.c | 3 +++ 1 file changed, 3 insertions(+) diff -puN drivers/char/amiserial.c~drivers-char-amiserialc-prevent-reading-uninitialized-stack-memory drivers/char/amiserial.c --- a/drivers/char/amiserial.c~drivers-char-amiserialc-prevent-reading-uninitialized-stack-memory +++ a/drivers/char/amiserial.c @@ -1342,6 +1342,9 @@ static int rs_ioctl(struct tty_struct *t local_irq_save(flags); cnow = info->state->icount; local_irq_restore(flags); + + memset(&icount, 0, sizeof(struct serial_icounter_struct)); + icount.cts = cnow.cts; icount.dsr = cnow.dsr; icount.rng = cnow.rng; _ Patches currently in -mm which might be from drosenberg@vsecurity.com are linux-next.patch drivers-serial-serial_corec-prevent-reading-uninitialized-stack-memory.patch drivers-char-amiserialc-prevent-reading-uninitialized-stack-memory.patch