From: akpm@linux-foundation.org
To: mm-commits@vger.kernel.org
Cc: roberto.sassu@polito.it, jmorris@namei.org,
kirkland@canonical.com, tyhicks@linux.vnet.ibm.com
Subject: + ecryptfs-call-__vfs_setxattr_noperm-in-ecryptfs_setxattr.patch added to -mm tree
Date: Mon, 27 Sep 2010 14:20:19 -0700 [thread overview]
Message-ID: <201009272120.o8RLKJd3017330@imap1.linux-foundation.org> (raw)
The patch titled
ecryptfs: call __vfs_setxattr_noperm() in ecryptfs_setxattr()
has been added to the -mm tree. Its filename is
ecryptfs-call-__vfs_setxattr_noperm-in-ecryptfs_setxattr.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: ecryptfs: call __vfs_setxattr_noperm() in ecryptfs_setxattr()
From: Roberto Sassu <roberto.sassu@polito.it>
Ecryptfs is a stackable filesystem which relies on lower filesystems the
ability of setting/getting extended attributes.
If there is a security module enabled on the system it updates the
'security' field of inodes according to the owned extended attribute set
with the function vfs_setxattr(). When this function is performed on a
ecryptfs filesystem the 'security' field is not updated for the lower
filesystem since the call security_inode_post_setxattr() is missing for
the lower inode.
This patch makes the function __vfs_setxattr_noperm() available for
modules and replaces the call to the setxattr() method of the lower inode
with the exported function.
Signed-off-by: Roberto Sassu <roberto.sassu@polito.it>
Cc: Tyler Hicks <tyhicks@linux.vnet.ibm.com>
Cc: Dustin Kirkland <kirkland@canonical.com>
Cc: James Morris <jmorris@namei.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
fs/ecryptfs/inode.c | 5 +++--
fs/xattr.c | 1 +
2 files changed, 4 insertions(+), 2 deletions(-)
diff -puN fs/ecryptfs/inode.c~ecryptfs-call-__vfs_setxattr_noperm-in-ecryptfs_setxattr fs/ecryptfs/inode.c
--- a/fs/ecryptfs/inode.c~ecryptfs-call-__vfs_setxattr_noperm-in-ecryptfs_setxattr
+++ a/fs/ecryptfs/inode.c
@@ -32,6 +32,7 @@
#include <linux/crypto.h>
#include <linux/fs_stack.h>
#include <linux/slab.h>
+#include <linux/xattr.h>
#include <asm/unaligned.h>
#include "ecryptfs_kernel.h"
@@ -1109,8 +1110,8 @@ ecryptfs_setxattr(struct dentry *dentry,
goto out;
}
mutex_lock(&lower_dentry->d_inode->i_mutex);
- rc = lower_dentry->d_inode->i_op->setxattr(lower_dentry, name, value,
- size, flags);
+ rc = __vfs_setxattr_noperm(lower_dentry, name, value,
+ size, flags);
mutex_unlock(&lower_dentry->d_inode->i_mutex);
out:
return rc;
diff -puN fs/xattr.c~ecryptfs-call-__vfs_setxattr_noperm-in-ecryptfs_setxattr fs/xattr.c
--- a/fs/xattr.c~ecryptfs-call-__vfs_setxattr_noperm-in-ecryptfs_setxattr
+++ a/fs/xattr.c
@@ -106,6 +106,7 @@ int __vfs_setxattr_noperm(struct dentry
return error;
}
+EXPORT_SYMBOL_GPL(__vfs_setxattr_noperm);
int
_
Patches currently in -mm which might be from roberto.sassu@polito.it are
ecryptfs-call-__vfs_setxattr_noperm-in-ecryptfs_setxattr.patch
reply other threads:[~2010-09-27 21:20 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201009272120.o8RLKJd3017330@imap1.linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=jmorris@namei.org \
--cc=kirkland@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=roberto.sassu@polito.it \
--cc=tyhicks@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox