From: akpm@linux-foundation.org
To: tipecaml@gmail.com, sage@inktank.com, mm-commits@vger.kernel.org
Subject: [merged] ceph-fix-dentry-reference-leak-in-ceph_encode_fh.patch removed from -mm tree
Date: Wed, 19 Dec 2012 12:39:27 -0800 [thread overview]
Message-ID: <20121219203928.3DF29200057@hpza10.eem.corp.google.com> (raw)
The patch titled
Subject: ceph: fix dentry reference leak in ceph_encode_fh()
has been removed from the -mm tree. Its filename was
ceph-fix-dentry-reference-leak-in-ceph_encode_fh.patch
This patch was dropped because it was merged into mainline or a subsystem tree
------------------------------------------------------
From: Cyril Roelandt <tipecaml@gmail.com>
Subject: ceph: fix dentry reference leak in ceph_encode_fh()
dput() was not called in the error path.
Signed-off-by: Cyril Roelandt <tipecaml@gmail.com>
Cc: Sage Weil <sage@inktank.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
fs/ceph/export.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff -puN fs/ceph/export.c~ceph-fix-dentry-reference-leak-in-ceph_encode_fh fs/ceph/export.c
--- a/fs/ceph/export.c~ceph-fix-dentry-reference-leak-in-ceph_encode_fh
+++ a/fs/ceph/export.c
@@ -56,13 +56,15 @@ static int ceph_encode_fh(struct inode *
struct ceph_nfs_confh *cfh = (void *)rawfh;
int connected_handle_length = sizeof(*cfh)/4;
int handle_length = sizeof(*fh)/4;
- struct dentry *dentry = d_find_alias(inode);
+ struct dentry *dentry;
struct dentry *parent;
/* don't re-export snaps */
if (ceph_snap(inode) != CEPH_NOSNAP)
return -EINVAL;
+ dentry = d_find_alias(inode);
+
/* if we found an alias, generate a connectable fh */
if (*max_len >= connected_handle_length && dentry) {
dout("encode_fh %p connectable\n", dentry);
_
Patches currently in -mm which might be from tipecaml@gmail.com are
origin.patch
reply other threads:[~2012-12-19 20:39 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121219203928.3DF29200057@hpza10.eem.corp.google.com \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=sage@inktank.com \
--cc=tipecaml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox