From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4E0F18C03F for ; Sat, 1 Nov 2025 03:08:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761966537; cv=none; b=OvBAsdKl7ek9paxMKUEwk7KguE09orlOILmS/hTXQqRWbh2PwihKuET6VvZUSTst6BCPSj9vrXWRji9lfsV6DSOpJ3aVVCBx6YBrIkZQeFjZKPFiIJ1wSgiKAbAF4yFksVIfFbJTO3oNrQX42F7OYieD6z2JiIXRdsF75POOMwU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761966537; c=relaxed/simple; bh=ZO3YHhQZS3E/oiZ73ziZjghXqJzqvI74cNGCPxXO7Co=; h=Date:To:From:Subject:Message-Id; b=pQjztmTt9LXkzNTzvAyfItCM8octmCDOPmks8TtEJrinB+VvR9A5p6OM5fQBY3lNCPbCr5SLwqElIkbmocbhR2pjkG+1Zg75ttb8+5J8N01ab7WKScPwxSsry0KPtqKFFLYrcg9P8vAly0Mx+i7Ow8l+rprz8Kf3vwlvPQUdnJk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=gsukVUF/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="gsukVUF/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6266AC4CEE7; Sat, 1 Nov 2025 03:08:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1761966536; bh=ZO3YHhQZS3E/oiZ73ziZjghXqJzqvI74cNGCPxXO7Co=; h=Date:To:From:Subject:From; b=gsukVUF/eBvvSLF7MTW2OBSnWaLzJDB1i8sdth6x5EmCPbAkmK8iiDqrTtvIKhi2e 9HrlRUc7g97Sauf0lMgTgBWygbqtGpG67S+b/TefIenRXApDURFGTc7dn7npGhr08z vU0xKo9gjvFycRxUT+8QD+Ya+7gCSrqJhGaXnXzE= Date: Fri, 31 Oct 2025 20:08:55 -0700 To: mm-commits@vger.kernel.org,shikemeng@huaweicloud.com,nphamcs@gmail.com,kasong@tencent.com,chrisl@kernel.org,bhe@redhat.com,baohua@kernel.org,youngjun.park@lge.com,akpm@linux-foundation.org From: Andrew Morton Subject: + mm-swap-use-swp_solidstate-to-determine-if-swap-is-rotational.patch added to mm-new branch Message-Id: <20251101030856.6266AC4CEE7@smtp.kernel.org> Precedence: bulk X-Mailing-List: mm-commits@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: The patch titled Subject: mm, swap: use SWP_SOLIDSTATE to determine if swap is rotational has been added to the -mm mm-new branch. Its filename is mm-swap-use-swp_solidstate-to-determine-if-swap-is-rotational.patch This patch will shortly appear at https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-swap-use-swp_solidstate-to-determine-if-swap-is-rotational.patch This patch will later appear in the mm-new branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Note, mm-new is a provisional staging ground for work-in-progress patches, and acceptance into mm-new is a notification for others take notice and to finish up reviews. Please do not hesitate to respond to review feedback and post updated versions to replace or incrementally fixup patches in mm-new. Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next via the mm-everything branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm and is updated there every 2-3 working days ------------------------------------------------------ From: Youngjun Park Subject: mm, swap: use SWP_SOLIDSTATE to determine if swap is rotational Date: Fri, 31 Oct 2025 15:50:08 +0900 The current non rotational check is unreliable as the device's rotational status can be changed by a user via sysfs. Use the more reliable SWP_SOLIDSTATE flag which is set at swapon time, to ensure the nr_rotate_swap count remains consistent. Plus, it is easy to read and simple. Link: https://lkml.kernel.org/r/20251031065011.40863-3-youngjun.park@lge.com Fixes: 81a0298bdfab ("mm, swap: don't use VMA based swap readahead if HDD is used as swap") Signed-off-by: Youngjun Park Reviewed-by: Baoquan He Cc: Barry Song Cc: Chris Li Cc: Kairui Song Cc: Kemeng Shi Cc: Nhat Pham Signed-off-by: Andrew Morton --- mm/swapfile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/mm/swapfile.c~mm-swap-use-swp_solidstate-to-determine-if-swap-is-rotational +++ a/mm/swapfile.c @@ -2913,7 +2913,7 @@ SYSCALL_DEFINE1(swapoff, const char __us if (p->flags & SWP_CONTINUED) free_swap_count_continuations(p); - if (!p->bdev || !bdev_nonrot(p->bdev)) + if (!(p->flags & SWP_SOLIDSTATE)) atomic_dec(&nr_rotate_swap); mutex_lock(&swapon_mutex); _ Patches currently in -mm which might be from youngjun.park@lge.com are mm-swap-fix-memory-leak-in-setup_clusters-error-path.patch mm-swap-use-swp_solidstate-to-determine-if-swap-is-rotational.patch mm-swap-remove-redundant-comment-for-read_swap_cache_async.patch mm-swap-change-swap_alloc_slow-to-void.patch mm-swap-remove-scan_swap_map_slots-references-from-comments.patch