From: Andrew Morton <akpm@linux-foundation.org>
To: mm-commits@vger.kernel.org,senozhatsky@chromium.org,minchan@kernel.org,zhuhui@kylinos.cn,akpm@linux-foundation.org
Subject: [merged mm-stable] zsmalloc-return-ebusy-for-zspage-migration-lock-contention.patch removed from -mm tree
Date: Sat, 28 Mar 2026 17:42:26 -0700 [thread overview]
Message-ID: <20260329004227.6AE1BC4CEF7@smtp.kernel.org> (raw)
The quilt patch titled
Subject: zsmalloc: return -EBUSY for zspage migration lock contention
has been removed from the -mm tree. Its filename was
zsmalloc-return-ebusy-for-zspage-migration-lock-contention.patch
This patch was dropped because it was merged into the mm-stable branch
of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
------------------------------------------------------
From: teawater <zhuhui@kylinos.cn>
Subject: zsmalloc: return -EBUSY for zspage migration lock contention
Date: Thu, 19 Mar 2026 14:59:24 +0800
movable_operations::migrate_page() should return an appropriate error code
for temporary migration failures so the migration core can handle them
correctly.
zs_page_migrate() currently returns -EINVAL when zspage_write_trylock()
fails. That path reflects transient lock contention, not invalid input,
so -EINVAL is clearly wrong.
However, -EAGAIN is also inappropriate here: the zspage's reader-lock
owner may hold the lock for an unbounded duration due to slow
decompression or reader-lock owner preemption. Since migration retries
are bounded by NR_MAX_MIGRATE_PAGES_RETRY and performed with virtually no
delay between attempts, there is no guarantee the lock will be released in
time for a retry to succeed. -EAGAIN implies "try again soon", which does
not hold in this case.
Return -EBUSY instead, which more accurately conveys that the resource is
occupied and migration cannot proceed at this time.
Link: https://lkml.kernel.org/r/20260319065924.69337-1-hui.zhu@linux.dev
Signed-off-by: teawater <zhuhui@kylinos.cn>
Acked-by: Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: Minchan Kim <minchan@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/zsmalloc.c | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
--- a/mm/zsmalloc.c~zsmalloc-return-ebusy-for-zspage-migration-lock-contention
+++ a/mm/zsmalloc.c
@@ -1727,7 +1727,19 @@ static int zs_page_migrate(struct page *
if (!zspage_write_trylock(zspage)) {
spin_unlock(&class->lock);
write_unlock(&pool->lock);
- return -EINVAL;
+ /*
+ * Return -EBUSY but not -EAGAIN: the zspage's reader-lock
+ * owner may hold the lock for an unbounded duration due to a
+ * slow decompression or reader-lock owner preemption.
+ * Since migration retries are bounded by
+ * NR_MAX_MIGRATE_PAGES_RETRY and performed with virtually no
+ * delay between attempts, there is no guarantee the lock will
+ * be released in time for a retry to succeed.
+ * -EAGAIN implies "try again soon", which does not hold here.
+ * -EBUSY more accurately conveys "resource is occupied,
+ * migration cannot proceed".
+ */
+ return -EBUSY;
}
/* We're committed, tell the world that this is a Zsmalloc page. */
_
Patches currently in -mm which might be from zhuhui@kylinos.cn are
mm-memcontrol-batch-memcg-charging-in-__memcg_slab_post_alloc_hook.patch
reply other threads:[~2026-03-29 0:42 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260329004227.6AE1BC4CEF7@smtp.kernel.org \
--to=akpm@linux-foundation.org \
--cc=minchan@kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=senozhatsky@chromium.org \
--cc=zhuhui@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox