From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96CAB389471 for ; Tue, 31 Mar 2026 18:29:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774981790; cv=none; b=JH+XtmtfRZS7dTJC8PVBIHFCBSxeX+wVOt2hJi/ly2HQWPQBZ94AMUxUds47WVvxWDlz5Ffd+9zNqCyNUvv7CWSzws1pUEM9CZFqmHlNUahqJUKhOaVT/ty21eazYB5DoZTgz8GfF3B6clfKou5vo+UK9/V5YcE4kwNAIrSDwFk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774981790; c=relaxed/simple; bh=du2DL6HcMGJgrqBqk/U7AoB2B1J07zNLN0/lh3itaBY=; h=Date:To:From:Subject:Message-Id; b=DaerkGTAe3nnPdhCzbGhrin96hQcl1gm76YReBXpiPPaXcaGJ1ALDo9OzyrB70hcdAviwvxLcL/pZ/VLtnmm1UMh+HA1VMvkVLI4z/eJrP9oOsQ78m92ZEYnzX3e0gEpVjjVsWKsf0pAkZneb+0a9G1ZYOu3akqzh9WLkw8iCKg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=sw3aurkf; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="sw3aurkf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3BC62C19423; Tue, 31 Mar 2026 18:29:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1774981790; bh=du2DL6HcMGJgrqBqk/U7AoB2B1J07zNLN0/lh3itaBY=; h=Date:To:From:Subject:From; b=sw3aurkfoFGgFlslubF49DbMEEQuLZijkvar4VJSxDdRqRRr7MrZwxteLV9zznDH1 WLjYNWv5/OaT8ziwJ7K2wH3GDjCNyYxv1Lmq/mkmV+mUhE0XgaI5MkICOBUzQqZpZu VzfTPos8sgbmeqaBBdq9dCPNQxJvXkmx/YIoxtcc= Date: Tue, 31 Mar 2026 11:29:49 -0700 To: mm-commits@vger.kernel.org,surenb@google.com,akpm@linux-foundation.org From: Andrew Morton Subject: [to-be-updated] mm-use-vma_start_write_killable-in-process_vma_walk_lock.patch removed from -mm tree Message-Id: <20260331182950.3BC62C19423@smtp.kernel.org> Precedence: bulk X-Mailing-List: mm-commits@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: The quilt patch titled Subject: mm: use vma_start_write_killable() in process_vma_walk_lock() has been removed from the -mm tree. Its filename was mm-use-vma_start_write_killable-in-process_vma_walk_lock.patch This patch was dropped because an updated version will be issued ------------------------------------------------------ From: Suren Baghdasaryan Subject: mm: use vma_start_write_killable() in process_vma_walk_lock() Date: Fri, 27 Mar 2026 13:54:56 -0700 Replace vma_start_write() with vma_start_write_killable() when process_vma_walk_lock() is used with PGWALK_WRLOCK option. Adjust its direct and indirect users to check for a possible error and handle it. Ensure users handle EINTR correctly and do not ignore it. When queue_pages_range() fails, check whether it failed due to a fatal signal or some other reason and return appropriate error. Link: https://lkml.kernel.org/r/20260327205457.604224-6-surenb@google.com Signed-off-by: Suren Baghdasaryan Suggested-by: Matthew Wilcox Cc: Alexander Gordeev Cc: Alistair Popple Cc: Baolin Wang Cc: Barry Song Cc: Byungchul Park Cc: Christian Borntraeger Cc: Claudio Imbrenda Cc: David Hildenbrand Cc: Dev Jain Cc: Gerald Schaefer Cc: Gregory Price Cc: Heiko Carstens Cc: "Huang, Ying" Cc: Jann Horn Cc: Janosch Frank Cc: Joshua Hahn Cc: Kees Cook Cc: Lance Yang Cc: Liam R. Howlett Cc: Lorenzo Stoakes Cc: Lorenzo Stoakes (Oracle) Cc: Madhavan Srinivasan Cc: Matthew Brost Cc: Michael Ellerman Cc: Michal Hocko Cc: Mike Rapoport Cc: Nicholas Piggin Cc: Nico Pache Cc: Pedro Falcato Cc: Rakie Kim Cc: Ritesh Harjani (IBM) Cc: Ryan Roberts Cc: Sven Schnelle Cc: Vasily Gorbik Cc: Vlastimil Babka Cc: Zi Yan Signed-off-by: Andrew Morton --- fs/proc/task_mmu.c | 12 ++++++------ mm/mempolicy.c | 10 +++++++++- mm/pagewalk.c | 22 +++++++++++++++------- 3 files changed, 30 insertions(+), 14 deletions(-) --- a/fs/proc/task_mmu.c~mm-use-vma_start_write_killable-in-process_vma_walk_lock +++ a/fs/proc/task_mmu.c @@ -1774,15 +1774,15 @@ static ssize_t clear_refs_write(struct f struct vm_area_struct *vma; enum clear_refs_types type; int itype; - int rv; + int err; if (count > sizeof(buffer) - 1) count = sizeof(buffer) - 1; if (copy_from_user(buffer, buf, count)) return -EFAULT; - rv = kstrtoint(strstrip(buffer), 10, &itype); - if (rv < 0) - return rv; + err = kstrtoint(strstrip(buffer), 10, &itype); + if (err) + return err; type = (enum clear_refs_types)itype; if (type < CLEAR_REFS_ALL || type >= CLEAR_REFS_LAST) return -EINVAL; @@ -1824,7 +1824,7 @@ static ssize_t clear_refs_write(struct f 0, mm, 0, -1UL); mmu_notifier_invalidate_range_start(&range); } - walk_page_range(mm, 0, -1, &clear_refs_walk_ops, &cp); + err = walk_page_range(mm, 0, -1, &clear_refs_walk_ops, &cp); if (type == CLEAR_REFS_SOFT_DIRTY) { mmu_notifier_invalidate_range_end(&range); flush_tlb_mm(mm); @@ -1837,7 +1837,7 @@ out_mm: } put_task_struct(task); - return count; + return err ? : count; } const struct file_operations proc_clear_refs_operations = { --- a/mm/mempolicy.c~mm-use-vma_start_write_killable-in-process_vma_walk_lock +++ a/mm/mempolicy.c @@ -969,6 +969,7 @@ static const struct mm_walk_ops queue_pa * (a hugetlbfs page or a transparent huge page being counted as 1). * -EIO - a misplaced page found, when MPOL_MF_STRICT specified without MOVEs. * -EFAULT - a hole in the memory range, when MPOL_MF_DISCONTIG_OK unspecified. + * -EINTR - walk got terminated due to pending fatal signal. */ static long queue_pages_range(struct mm_struct *mm, unsigned long start, unsigned long end, @@ -1545,7 +1546,14 @@ static long do_mbind(unsigned long start flags | MPOL_MF_INVERT | MPOL_MF_WRLOCK, &pagelist); if (nr_failed < 0) { - err = nr_failed; + /* + * queue_pages_range() might override the original error with -EFAULT. + * Confirm that fatal signals are still treated correctly. + */ + if (fatal_signal_pending(current)) + err = -EINTR; + else + err = nr_failed; nr_failed = 0; } else { vma_iter_init(&vmi, mm, start); --- a/mm/pagewalk.c~mm-use-vma_start_write_killable-in-process_vma_walk_lock +++ a/mm/pagewalk.c @@ -443,14 +443,13 @@ static inline void process_mm_walk_lock( mmap_assert_write_locked(mm); } -static inline void process_vma_walk_lock(struct vm_area_struct *vma, - enum page_walk_lock walk_lock) +static int process_vma_walk_lock(struct vm_area_struct *vma, + enum page_walk_lock walk_lock) { #ifdef CONFIG_PER_VMA_LOCK switch (walk_lock) { case PGWALK_WRLOCK: - vma_start_write(vma); - break; + return vma_start_write_killable(vma); case PGWALK_WRLOCK_VERIFY: vma_assert_write_locked(vma); break; @@ -462,6 +461,7 @@ static inline void process_vma_walk_lock break; } #endif + return 0; } /* @@ -505,7 +505,9 @@ int walk_page_range_mm_unsafe(struct mm_ if (ops->pte_hole) err = ops->pte_hole(start, next, -1, &walk); } else { /* inside vma */ - process_vma_walk_lock(vma, ops->walk_lock); + err = process_vma_walk_lock(vma, ops->walk_lock); + if (err) + break; walk.vma = vma; next = min(end, vma->vm_end); vma = find_vma(mm, vma->vm_end); @@ -722,6 +724,7 @@ int walk_page_range_vma_unsafe(struct vm .vma = vma, .private = private, }; + int err; if (start >= end || !walk.mm) return -EINVAL; @@ -729,7 +732,9 @@ int walk_page_range_vma_unsafe(struct vm return -EINVAL; process_mm_walk_lock(walk.mm, ops->walk_lock); - process_vma_walk_lock(vma, ops->walk_lock); + err = process_vma_walk_lock(vma, ops->walk_lock); + if (err) + return err; return __walk_page_range(start, end, &walk); } @@ -752,6 +757,7 @@ int walk_page_vma(struct vm_area_struct .vma = vma, .private = private, }; + int err; if (!walk.mm) return -EINVAL; @@ -759,7 +765,9 @@ int walk_page_vma(struct vm_area_struct return -EINVAL; process_mm_walk_lock(walk.mm, ops->walk_lock); - process_vma_walk_lock(vma, ops->walk_lock); + err = process_vma_walk_lock(vma, ops->walk_lock); + if (err) + return err; return __walk_page_range(vma->vm_start, vma->vm_end, &walk); } _ Patches currently in -mm which might be from surenb@google.com are kvm-ppc-use-vma_start_write_killable-in-kvmppc_memslot_page_merge.patch mm-vmscan-prevent-mglru-reclaim-from-pinning-address-space.patch