From: Andrew Morton <akpm@linux-foundation.org>
To: mm-commits@vger.kernel.org,bsingharora@gmail.com,include@grrlz.net,akpm@linux-foundation.org
Subject: + taskstats-fold-the-two-cpumask-handlers-into-one.patch added to mm-nonmm-unstable branch
Date: Tue, 28 Jul 2026 17:00:04 -0700 [thread overview]
Message-ID: <20260729000005.1FDBB1F00A3A@smtp.kernel.org> (raw)
The patch titled
Subject: taskstats: fold the two cpumask handlers into one
has been added to the -mm mm-nonmm-unstable branch. Its filename is
taskstats-fold-the-two-cpumask-handlers-into-one.patch
This patch will shortly appear at
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/taskstats-fold-the-two-cpumask-handlers-into-one.patch
This patch will later appear in the mm-nonmm-unstable branch at
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next via various
branches at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there most days
------------------------------------------------------
From: Bradley Morgan <include@grrlz.net>
Subject: taskstats: fold the two cpumask handlers into one
Date: Tue, 28 Jul 2026 20:21:04 +0000
cmd_attr_register_cpumask() and cmd_attr_deregister_cpumask() differed
only in which attribute they parsed and which action they passed on, so
take both as arguments. __free(free_cpumask_var) then removes the goto.
No functional change.
Link: https://lore.kernel.org/20260728202104.17839-3-include@grrlz.net
Signed-off-by: Bradley Morgan <include@grrlz.net>
Cc: Balbir Singh <bsingharora@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
kernel/taskstats.c | 38 ++++++++++++--------------------------
1 file changed, 12 insertions(+), 26 deletions(-)
--- a/kernel/taskstats.c~taskstats-fold-the-two-cpumask-handlers-into-one
+++ a/kernel/taskstats.c
@@ -448,36 +448,18 @@ static int cgroupstats_user_cmd(struct s
return send_reply(rep_skb, info);
}
-static int cmd_attr_register_cpumask(struct genl_info *info)
+static int cmd_attr_cpumask(struct genl_info *info, int attr,
+ enum actions action)
{
- cpumask_var_t mask;
+ cpumask_var_t mask __free(free_cpumask_var) = CPUMASK_VAR_NULL;
int rc;
if (!alloc_cpumask_var(&mask, GFP_KERNEL))
return -ENOMEM;
- rc = parse(info->attrs[TASKSTATS_CMD_ATTR_REGISTER_CPUMASK], mask);
+ rc = parse(info->attrs[attr], mask);
if (rc < 0)
- goto out;
- rc = add_del_listener(info->snd_portid, mask, REGISTER);
-out:
- free_cpumask_var(mask);
- return rc;
-}
-
-static int cmd_attr_deregister_cpumask(struct genl_info *info)
-{
- cpumask_var_t mask;
- int rc;
-
- if (!alloc_cpumask_var(&mask, GFP_KERNEL))
- return -ENOMEM;
- rc = parse(info->attrs[TASKSTATS_CMD_ATTR_DEREGISTER_CPUMASK], mask);
- if (rc < 0)
- goto out;
- rc = add_del_listener(info->snd_portid, mask, DEREGISTER);
-out:
- free_cpumask_var(mask);
- return rc;
+ return rc;
+ return add_del_listener(info->snd_portid, mask, action);
}
static size_t taskstats_packet_size(void)
@@ -552,9 +534,13 @@ err:
static int taskstats_user_cmd(struct sk_buff *skb, struct genl_info *info)
{
if (info->attrs[TASKSTATS_CMD_ATTR_REGISTER_CPUMASK])
- return cmd_attr_register_cpumask(info);
+ return cmd_attr_cpumask(info,
+ TASKSTATS_CMD_ATTR_REGISTER_CPUMASK,
+ REGISTER);
else if (info->attrs[TASKSTATS_CMD_ATTR_DEREGISTER_CPUMASK])
- return cmd_attr_deregister_cpumask(info);
+ return cmd_attr_cpumask(info,
+ TASKSTATS_CMD_ATTR_DEREGISTER_CPUMASK,
+ DEREGISTER);
else if (info->attrs[TASKSTATS_CMD_ATTR_PID])
return cmd_attr_pid(info);
else if (info->attrs[TASKSTATS_CMD_ATTR_TGID])
_
Patches currently in -mm which might be from include@grrlz.net are
lib-string-fix-memchr_inv-for-large-ranges.patch
signal-avoid-shared-siginfo-namespace-rewrites.patch
taskstats-fix-cpumask-parsing-cutting-off-the-last-character.patch
taskstats-drop-the-dead-null-attribute-check-in-parse.patch
taskstats-fold-the-two-cpumask-handlers-into-one.patch
reply other threads:[~2026-07-29 0:00 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260729000005.1FDBB1F00A3A@smtp.kernel.org \
--to=akpm@linux-foundation.org \
--cc=bsingharora@gmail.com \
--cc=include@grrlz.net \
--cc=mm-commits@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox