From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1BC81EB5FD for ; Sat, 12 Sep 2026 07:24:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789197900; cv=none; b=BC7BluY9v63vMz84uFc3eSH5uChZEz4jaUkWVQCA1QC28bbmEkT+/tDOFDEhh6ZrcqFeFhzapglIZHgWOZn2UDpyaiNxPzjnrR48Xn404n9qf0tHBmr81DBxwoygq/0kkka6dpbmw23amJYxyJDB/VWE94B6hHHaERoHUo3Qn9c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789197900; c=relaxed/simple; bh=IaJ8FylRy/w7//kvM2XLsLRZ5mmxa93AO5pIwqlXmoc=; h=Date:To:From:Subject:Message-Id; b=Wz2DhghpvGf96ZOFY6qt1HhHvm55FFO+I8X72fVrqvc3iZfrQqnIWPr3ItmUy6F3xAwn9snF25P36WqsQmakX5D8upci5mFmc39kzZM6a9DlMyO1LMc6b4kCZmDdMwCiScJBMoy32VfcNuKFjFVvxCMWaiGZe6HOUHq2dtUWkQc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=oMndp18H; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="oMndp18H" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 585291F000FF; Sat, 12 Sep 2026 07:24:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=korg; t=1789197898; bh=o95yHZP49FD/CTIi0nEUVBP8HIKC6725ebSOBzxEnwk=; h=Date:To:From:Subject; b=oMndp18HlYquFn+8URMLWLBDIUKxC9B472a+nAFC4J8dJoKspRFgeRg2gxnJM+toE BwxrzHOuXLFsk8bq0YbMKp+A27RyjUrgdCSYIwcgZ3lAmpspINuvrMnGpTjqs2iM75 4tXRCA1pu3+3oAJwkC1V3G6gvKvPkkwP9U5w5LMk= Date: Sat, 12 Sep 2026 00:24:57 -0700 To: mm-commits@vger.kernel.org,willy@infradead.org,vbabka@kernel.org,usama.arif@linux.dev,pfalcato@suse.de,paulmck@kernel.org,ljs@kernel.org,liam@infradead.org,jannh@google.com,david@kernel.org,surenb@google.com,akpm@linux-foundation.org From: Andrew Morton Subject: + proc-task_mmu-remove-unnecessary-inlines-in-function-definitions.patch added to mm-new branch Message-Id: <20260912072458.585291F000FF@smtp.kernel.org> Precedence: bulk X-Mailing-List: mm-commits@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: The patch titled Subject: proc/task_mmu: remove unnecessary inlines in function definitions has been added to the -mm mm-new branch. Its filename is proc-task_mmu-remove-unnecessary-inlines-in-function-definitions.patch This patch will shortly appear at https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/proc-task_mmu-remove-unnecessary-inlines-in-function-definitions.patch This patch will later appear in the mm-new branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Note, mm-new is a provisional staging ground for work-in-progress patches, and acceptance into mm-new is a notification for others take notice and to finish up reviews. Please do not hesitate to respond to review feedback and post updated versions to replace or incrementally fixup patches in mm-new. The mm-new branch of mm.git is not included in linux-next If a few days of testing in mm-new is successful, the patch will me moved into mm.git's mm-unstable branch, which is included in linux-next Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next via various branches at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm and is updated there most days ------------------------------------------------------ From: Suren Baghdasaryan Subject: proc/task_mmu: remove unnecessary inlines in function definitions Date: Fri, 11 Sep 2026 12:41:40 -0700 It was pointed out in the previous reviews of this code that many functions are specified as inline, which is unnecessary as the compile can make that decision by itself. Cleanup these definitions. No change in the resulting binary file size with gcc v15.2.0. No functional change intended. Link: https://lore.kernel.org/20260911194145.1781926-3-surenb@google.com Signed-off-by: Suren Baghdasaryan Signed-off-by: Andrew Morton Reviewed-by: Liam R. Howlett (Oracle) Reviewed-by: Lorenzo Stoakes (ARM) Acked-by: Usama Arif Acked-by: David Hildenbrand (Arm) Cc: Jann Horn Cc: Matthew Wilcox (Oracle) Cc: "Paul E . McKenney" Cc: Pedro Falcato Cc: Vlastimil Babka --- fs/proc/task_mmu.c | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) --- a/fs/proc/task_mmu.c~proc-task_mmu-remove-unnecessary-inlines-in-function-definitions +++ a/fs/proc/task_mmu.c @@ -130,7 +130,7 @@ static void release_task_mempolicy(struc } #endif -static inline int lock_ctx_mm(struct proc_maps_locking_ctx *lock_ctx) +static int lock_ctx_mm(struct proc_maps_locking_ctx *lock_ctx) { int ret = mmap_read_lock_killable(lock_ctx->mm); @@ -140,7 +140,7 @@ static inline int lock_ctx_mm(struct pro return ret; } -static inline void unlock_ctx_mm(struct proc_maps_locking_ctx *lock_ctx) +static void unlock_ctx_mm(struct proc_maps_locking_ctx *lock_ctx) { mmap_read_unlock(lock_ctx->mm); lock_ctx->mmap_locked = false; @@ -177,8 +177,8 @@ static struct vm_area_struct *get_next_v return vma; } -static inline bool fallback_to_mmap_lock(struct proc_maps_private *priv, - loff_t pos) +static bool fallback_to_mmap_lock(struct proc_maps_private *priv, + loff_t pos) { struct proc_maps_locking_ctx *lock_ctx = &priv->lock_ctx; @@ -194,7 +194,7 @@ static inline bool fallback_to_mmap_lock return true; } -static inline void drop_rcu(struct proc_maps_private *priv) +static void drop_rcu(struct proc_maps_private *priv) { if (priv->lock_ctx.mmap_locked) return; @@ -202,7 +202,7 @@ static inline void drop_rcu(struct proc_ rcu_read_unlock(); } -static inline void reacquire_rcu(struct proc_maps_private *priv) +static void reacquire_rcu(struct proc_maps_private *priv) { if (priv->lock_ctx.mmap_locked) return; @@ -1230,7 +1230,7 @@ static const struct mm_walk_ops smaps_sh .walk_lock = PGWALK_VMA_RDLOCK_VERIFY, }; -static inline const struct mm_walk_ops * +static const struct mm_walk_ops * get_smaps_walk_ops(struct proc_maps_private *priv) { if (priv->lock_ctx.mmap_locked) @@ -1238,7 +1238,7 @@ get_smaps_walk_ops(struct proc_maps_priv return &smaps_walk_vma_lock_ops; } -static inline const struct mm_walk_ops * +static const struct mm_walk_ops * get_smaps_shmem_walk_ops(struct proc_maps_private *priv) { if (priv->lock_ctx.mmap_locked) @@ -1572,7 +1572,7 @@ struct clear_refs_private { enum clear_refs_types type; }; -static inline bool pte_is_pinned(struct vm_area_struct *vma, unsigned long addr, pte_t pte) +static bool pte_is_pinned(struct vm_area_struct *vma, unsigned long addr, pte_t pte) { struct folio *folio; @@ -1588,8 +1588,8 @@ static inline bool pte_is_pinned(struct return folio_maybe_dma_pinned(folio); } -static inline void clear_soft_dirty(struct vm_area_struct *vma, - unsigned long addr, pte_t *pte) +static void clear_soft_dirty(struct vm_area_struct *vma, unsigned long addr, + pte_t *pte) { if (!pgtable_supports_soft_dirty()) return; @@ -1620,7 +1620,7 @@ static inline void clear_soft_dirty(stru } #if defined(CONFIG_TRANSPARENT_HUGEPAGE) -static inline void clear_soft_dirty_pmd(struct vm_area_struct *vma, +static void clear_soft_dirty_pmd(struct vm_area_struct *vma, unsigned long addr, pmd_t *pmdp) { pmd_t old, pmd = *pmdp; @@ -1646,7 +1646,7 @@ static inline void clear_soft_dirty_pmd( } } #else -static inline void clear_soft_dirty_pmd(struct vm_area_struct *vma, +static void clear_soft_dirty_pmd(struct vm_area_struct *vma, unsigned long addr, pmd_t *pmdp) { } @@ -1846,7 +1846,7 @@ struct pagemapread { #define PM_END_OF_BUFFER 1 -static inline pagemap_entry_t make_pme(u64 frame, u64 flags) +static pagemap_entry_t make_pme(u64 frame, u64 flags) { return (pagemap_entry_t) { .pme = (frame & PM_PFRAME_MASK) | flags }; } @@ -3388,7 +3388,7 @@ static const struct mm_walk_ops show_num .walk_lock = PGWALK_VMA_RDLOCK_VERIFY, }; -static inline const struct mm_walk_ops * +static const struct mm_walk_ops * get_show_numa_ops(struct proc_maps_private *priv) { if (priv->lock_ctx.mmap_locked) _ Patches currently in -mm which might be from surenb@google.com are proc-task_mmu-remove-unnecessary-helpers.patch proc-task_mmu-remove-unnecessary-inlines-in-function-definitions.patch proc-task_mmu-clarify-shmem-mapping-walk-conditions-in-smap_gather_stats.patch proc-task_mmu-remove-special-casing-of-smap_gather_stats-start-parameter.patch proc-task_mmu-change-proc_get_vma-to-stop-returning-gate-vma-at-the-end.patch proc-task_mmu-read-proc-pid-smaps_rollup-under-per-vma-lock.patch selftests-proc-add-proc-pid-smaps_rollup-tearing-tests.patch