From: Andrew Morton <akpm@linux-foundation.org>
To: mm-commits@vger.kernel.org,vbabka@kernel.org,surenb@google.com,
shuah@kernel.org,rppt@kernel.org,mhocko@suse.com,ljs@kernel.org,
liam@infradead.org,david@kernel.org,akpm@linux-foundation.org,
lihongfu@kylinos.cn
Subject: [to-be-updated] selftests-mm-mlock2-tests-fix-fclosenull-in-is_vmflag_set.patch removed from -mm tree
Date: Fri, 13 Nov 2026 18:44:19 -0800 [thread overview]
Message-ID: <20261114024419.90B231F000C4@smtp.kernel.org> (raw)
The quilt patch titled
Subject: selftests/mm: mlock2-tests: fix fclose(NULL) in is_vmflag_set()
has been removed from the -mm tree. Its filename was
selftests-mm-mlock2-tests-fix-fclosenull-in-is_vmflag_set.patch
This patch was dropped because an updated version will be issued
------------------------------------------------------
From: Hongfu Li <lihongfu@kylinos.cn>
Subject: selftests/mm: mlock2-tests: fix fclose(NULL) in is_vmflag_set()
Date: Wed, 04 Nov 2026 16:49:10 +0800
is_vmflag_set() jumps to the shared 'out' label when seek_to_smaps_entry()
fails. smaps is NULL on that path, and the code at the 'out' label calls
fclose(smaps) unconditionally. fclose(NULL) is undefined behaviour, so
the test crashes before it can report a test result.
Link: https://lore.kernel.org/20261104-for-mlock2-v1-1-57e6dd74c2bd@kylinos.cn
Signed-off-by: Hongfu Li <lihongfu@kylinos.cn>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Cc: David Hildenbrand <david@kernel.org>
Cc: Lorenzo Stoakes <ljs@kernel.org>
Cc: Liam R. Howlett <liam@infradead.org>
Cc: Vlastimil Babka <vbabka@kernel.org>
Cc: Mike Rapoport <rppt@kernel.org>
Cc: Suren Baghdasaryan <surenb@google.com>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Shuah Khan <shuah@kernel.org>
---
tools/testing/selftests/mm/mlock2-tests.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/tools/testing/selftests/mm/mlock2-tests.c~selftests-mm-mlock2-tests-fix-fclosenull-in-is_vmflag_set
+++ a/tools/testing/selftests/mm/mlock2-tests.c
@@ -66,7 +66,7 @@ static bool is_vmflag_set(unsigned long
smaps = seek_to_smaps_entry(addr);
if (!smaps) {
ksft_print_msg("Unable to parse /proc/self/smaps\n");
- goto out;
+ return false;
}
while (getline(&line, &size, smaps) > 0) {
_
Patches currently in -mm which might be from lihongfu@kylinos.cn are
mm-hugetlb-charge-hugetlb-cgroup-and-memcg-in-alloc_hugetlb_folio_reserve.patch
reply other threads:[~2026-11-14 2:44 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261114024419.90B231F000C4@smtp.kernel.org \
--to=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=liam@infradead.org \
--cc=lihongfu@kylinos.cn \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=mm-commits@vger.kernel.org \
--cc=rppt@kernel.org \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox