From: Andrew Morton <akpm@linux-foundation.org>
To: mm-commits@vger.kernel.org,wfelipe@google.com,ryan.roberts@arm.com,
rppt@kernel.org,mhiramat@kernel.org,leitao@debian.org,ekffu200098@gmail.com,
brauner@kernel.org,blum@kernel.org,akpm@linux-foundation.org
Subject: + init-remove-strlcat-and-sprintf-from-do_one_initcall.patch added to mm-nonmm-unstable branch
Date: Sat, 14 Nov 2026 15:21:28 -0800 [thread overview]
Message-ID: <20261114232129.35F1C1F000C4@smtp.kernel.org> (raw)
The patch titled
Subject: init: remove strlcat() and sprintf() from do_one_initcall()
has been added to the -mm mm-nonmm-unstable branch. Its filename is
init-remove-strlcat-and-sprintf-from-do_one_initcall.patch
This patch will shortly appear at
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/init-remove-strlcat-and-sprintf-from-do_one_initcall.patch
This patch will later appear in the mm-nonmm-unstable branch at
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next via various
branches at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there most days
------------------------------------------------------
From: Thorsten Blum <blum@kernel.org>
Subject: init: remove strlcat() and sprintf() from do_one_initcall()
Date: Sat, 14 Nov 2026 12:05:31 +0100
In preparation for removing strlcat() from the kernel [1], format the
warning directly in WARN(). This also removes the temporary 64-byte
buffer and the sprintf() call while preserving the warning text.
Link: https://lore.kernel.org/20261114110531.26138-2-blum@kernel.org
Link: https://github.com/KSPP/linux/issues/370 [1]
Signed-off-by: Thorsten Blum <blum@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Christian Brauner <brauner@kernel.org>
Cc: Sang-Heon Jeon <ekffu200098@gmail.com>
Cc: Breno Leitao <leitao@debian.org>
Cc: Mike Rapoport <rppt@kernel.org>
Cc: Ryan Roberts <ryan.roberts@arm.com>
Cc: Wilson Felipe Pereira <wfelipe@google.com>
init/main.c | 21 +++++++++++----------
1 file changed, 11 insertions(+), 10 deletions(-)
--- a/init/main.c~init-remove-strlcat-and-sprintf-from-do_one_initcall
+++ a/init/main.c
@@ -1409,7 +1409,8 @@ static inline void do_trace_initcall_lev
int __init_or_module do_one_initcall(initcall_t fn)
{
int count = preempt_count();
- char msgbuf[64];
+ bool preempt_imbalanced;
+ bool irqs_left_disabled;
int ret;
if (initcall_blacklisted(fn))
@@ -1419,17 +1420,17 @@ int __init_or_module do_one_initcall(ini
ret = fn();
do_trace_initcall_finish(fn, ret);
- msgbuf[0] = 0;
-
- if (preempt_count() != count) {
- sprintf(msgbuf, "preemption imbalance ");
+ preempt_imbalanced = preempt_count() != count;
+ if (preempt_imbalanced)
preempt_count_set(count);
- }
- if (irqs_disabled()) {
- strlcat(msgbuf, "disabled interrupts ", sizeof(msgbuf));
+
+ irqs_left_disabled = irqs_disabled();
+ if (irqs_left_disabled)
local_irq_enable();
- }
- WARN(msgbuf[0], "initcall %pS returned with %s\n", fn, msgbuf);
+
+ WARN(preempt_imbalanced || irqs_left_disabled, "initcall %pS returned with %s%s\n", fn,
+ preempt_imbalanced ? "preemption imbalance " : "",
+ irqs_left_disabled ? "disabled interrupts " : "");
add_latent_entropy();
return ret;
_
Patches currently in -mm which might be from blum@kernel.org are
init-reject-bare-rodata-parameter-before-architecture-parsing.patch
init-use-strscpy-in-do_initcalls.patch
init-use-kmalloc-in-do_initcalls.patch
init-remove-strlcat-and-sprintf-from-do_one_initcall.patch
reply other threads:[~2026-11-14 23:21 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261114232129.35F1C1F000C4@smtp.kernel.org \
--to=akpm@linux-foundation.org \
--cc=blum@kernel.org \
--cc=brauner@kernel.org \
--cc=ekffu200098@gmail.com \
--cc=leitao@debian.org \
--cc=mhiramat@kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=wfelipe@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox