From: Andrew Morton <akpm@linux-foundation.org>
To: mm-commits@vger.kernel.org,yukuai@fygo.io,xiao@kernel.org,song@kernel.org,
markus.stockhausen@collogia.de,magiclinan@didiglobal.com,hch@lst.de,
ebiggers@kernel.org,david.laight.linux@gmail.com,ardb@kernel.org,
antosha20xx@gmail.com,mc@raidlab.org,akpm@linux-foundation.org
Subject: + raid6-use-normal-stores-in-the-x86-x4-xor_syndrome-functions.patch added to mm-nonmm-unstable branch
Date: Sat, 21 Nov 2026 16:25:15 -0800 [thread overview]
Message-ID: <20261122002516.51B1F1F000C4@smtp.kernel.org> (raw)
In-Reply-To: <20261109030805.25709-1-mc@raidlab.org>
The patch titled
Subject: raid6: use normal stores in the x86 x4 xor_syndrome functions
has been added to the -mm mm-nonmm-unstable branch. Its filename is
raid6-use-normal-stores-in-the-x86-x4-xor_syndrome-functions.patch
This patch will shortly appear at
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/raid6-use-normal-stores-in-the-x86-x4-xor_syndrome-functions.patch
This patch will later appear in the mm-nonmm-unstable branch at
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next via various
branches at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there most days
------------------------------------------------------
From: Miroslav Cimerman <mc@raidlab.org>
Subject: raid6: use normal stores in the x86 x4 xor_syndrome functions
Date: Mon, 09 Nov 2026 03:08:05 +0000
xor_syndrome() updates P and Q in place for a read-modify-write. md calls
it twice on the same P/Q page per write, to remove the old data and to add
the new data. The x1 and x2 unrolled versions write P and Q with normal
stores since commit a582564b24be ("md/raid6 algorithms: xor_syndrome() for
SSE2"), which argued that non-temporal stores of less than a cache line
are slow, but kept non-temporal stores in the x4 version, as it writes
whole cache lines. The AVX2 and AVX-512 versions followed the same
pattern.
The non-temporal stores evict P and Q from the cache and the sfence waits
until they are written to memory, just before the second call reads the
same P and Q again, now from memory.
Use normal aligned stores in the x4 unrolled versions too, like the x1 and
x2 versions and the other architectures.
md RAID-6, 4 KiB random writes, md thread on one core, Xeon E5-2699 v3:
8+2 on null_blk (dm-raid): 85.6k -> 98.1k IOPS (+15%)
6+2 on 8 Intel Optane M10: 57.3k -> 62.1k IOPS (+8%)
Change in time per write in md's pattern (both calls and the 4 KiB copy
between them), kernel code built in userspace, one core, geometric
mean over 2-24 data disks, data in cache / DRAM:
avx2x4 (Xeon E5-2699 v3): -66% / -38%
avx512x4 (Xeon Gold 6130): -78% / -48%
sse2x4 (Core i5-2520M): -37% / -19%
Link: https://patch.msgid.link/20261109030805.25709-1-mc@raidlab.org
Signed-off-by: Miroslav Cimerman <mc@raidlab.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Tested-by: Anton Gavriliuk <antosha20xx@gmail.com>
Link: https://lore.kernel.org/CAAiJnjqrRo-75jg_Jrr0x2r85kY2g6_ZSH%2B8ukyJJ5UXyMb6pA@mail.gmail.com
Reviewed-by: Eric Biggers <ebiggers@kernel.org>
Cc: Song Liu <song@kernel.org>
Cc: Yu Kuai <yukuai@fygo.io>
Cc: Li Nan <magiclinan@didiglobal.com>
Cc: Xiao Ni <xiao@kernel.org>
Cc: Ard Biesheuvel <ardb@kernel.org>
Cc: David Laight <david.laight.linux@gmail.com>
Cc: Markus Stockhausen <markus.stockhausen@collogia.de>
lib/raid/raid6/x86/avx2.c | 16 ++++++++--------
lib/raid/raid6/x86/avx512.c | 16 ++++++++--------
lib/raid/raid6/x86/sse2.c | 16 ++++++++--------
3 files changed, 24 insertions(+), 24 deletions(-)
--- a/lib/raid/raid6/x86/avx2.c~raid6-use-normal-stores-in-the-x86-x4-xor_syndrome-functions
+++ a/lib/raid/raid6/x86/avx2.c
@@ -435,18 +435,18 @@ static void raid6_avx24_xor_syndrome(int
asm volatile("vpxor %ymm13,%ymm12,%ymm12");
asm volatile("vpxor %ymm15,%ymm14,%ymm14");
}
- asm volatile("vmovntdq %%ymm2,%0" : "=m" (p[d]));
- asm volatile("vmovntdq %%ymm3,%0" : "=m" (p[d+32]));
- asm volatile("vmovntdq %%ymm10,%0" : "=m" (p[d+64]));
- asm volatile("vmovntdq %%ymm11,%0" : "=m" (p[d+96]));
+ asm volatile("vmovdqa %%ymm2,%0" : "=m" (p[d]));
+ asm volatile("vmovdqa %%ymm3,%0" : "=m" (p[d+32]));
+ asm volatile("vmovdqa %%ymm10,%0" : "=m" (p[d+64]));
+ asm volatile("vmovdqa %%ymm11,%0" : "=m" (p[d+96]));
asm volatile("vpxor %0,%%ymm4,%%ymm4" : : "m" (q[d]));
asm volatile("vpxor %0,%%ymm6,%%ymm6" : : "m" (q[d+32]));
asm volatile("vpxor %0,%%ymm12,%%ymm12" : : "m" (q[d+64]));
asm volatile("vpxor %0,%%ymm14,%%ymm14" : : "m" (q[d+96]));
- asm volatile("vmovntdq %%ymm4,%0" : "=m" (q[d]));
- asm volatile("vmovntdq %%ymm6,%0" : "=m" (q[d+32]));
- asm volatile("vmovntdq %%ymm12,%0" : "=m" (q[d+64]));
- asm volatile("vmovntdq %%ymm14,%0" : "=m" (q[d+96]));
+ asm volatile("vmovdqa %%ymm4,%0" : "=m" (q[d]));
+ asm volatile("vmovdqa %%ymm6,%0" : "=m" (q[d+32]));
+ asm volatile("vmovdqa %%ymm12,%0" : "=m" (q[d+64]));
+ asm volatile("vmovdqa %%ymm14,%0" : "=m" (q[d+96]));
}
asm volatile("sfence" : : : "memory");
asm volatile("vzeroupper");
--- a/lib/raid/raid6/x86/avx512.c~raid6-use-normal-stores-in-the-x86-x4-xor_syndrome-functions
+++ a/lib/raid/raid6/x86/avx512.c
@@ -516,18 +516,18 @@ static void raid6_avx5124_xor_syndrome(i
:
: );
}
- asm volatile("vmovntdq %%zmm2,%0\n\t"
- "vmovntdq %%zmm3,%1\n\t"
- "vmovntdq %%zmm10,%2\n\t"
- "vmovntdq %%zmm11,%3\n\t"
+ asm volatile("vmovdqa64 %%zmm2,%0\n\t"
+ "vmovdqa64 %%zmm3,%1\n\t"
+ "vmovdqa64 %%zmm10,%2\n\t"
+ "vmovdqa64 %%zmm11,%3\n\t"
"vpxorq %4,%%zmm4,%%zmm4\n\t"
"vpxorq %5,%%zmm6,%%zmm6\n\t"
"vpxorq %6,%%zmm12,%%zmm12\n\t"
"vpxorq %7,%%zmm14,%%zmm14\n\t"
- "vmovntdq %%zmm4,%4\n\t"
- "vmovntdq %%zmm6,%5\n\t"
- "vmovntdq %%zmm12,%6\n\t"
- "vmovntdq %%zmm14,%7"
+ "vmovdqa64 %%zmm4,%4\n\t"
+ "vmovdqa64 %%zmm6,%5\n\t"
+ "vmovdqa64 %%zmm12,%6\n\t"
+ "vmovdqa64 %%zmm14,%7"
:
: "m" (p[d]), "m" (p[d+64]), "m" (p[d+128]),
"m" (p[d+192]), "m" (q[d]), "m" (q[d+64]),
--- a/lib/raid/raid6/x86/sse2.c~raid6-use-normal-stores-in-the-x86-x4-xor_syndrome-functions
+++ a/lib/raid/raid6/x86/sse2.c
@@ -432,18 +432,18 @@ static void raid6_sse24_xor_syndrome(int
asm volatile("pxor %xmm13,%xmm12");
asm volatile("pxor %xmm15,%xmm14");
}
- asm volatile("movntdq %%xmm2,%0" : "=m" (p[d]));
- asm volatile("movntdq %%xmm3,%0" : "=m" (p[d+16]));
- asm volatile("movntdq %%xmm10,%0" : "=m" (p[d+32]));
- asm volatile("movntdq %%xmm11,%0" : "=m" (p[d+48]));
+ asm volatile("movdqa %%xmm2,%0" : "=m" (p[d]));
+ asm volatile("movdqa %%xmm3,%0" : "=m" (p[d+16]));
+ asm volatile("movdqa %%xmm10,%0" : "=m" (p[d+32]));
+ asm volatile("movdqa %%xmm11,%0" : "=m" (p[d+48]));
asm volatile("pxor %0,%%xmm4" : : "m" (q[d]));
asm volatile("pxor %0,%%xmm6" : : "m" (q[d+16]));
asm volatile("pxor %0,%%xmm12" : : "m" (q[d+32]));
asm volatile("pxor %0,%%xmm14" : : "m" (q[d+48]));
- asm volatile("movntdq %%xmm4,%0" : "=m" (q[d]));
- asm volatile("movntdq %%xmm6,%0" : "=m" (q[d+16]));
- asm volatile("movntdq %%xmm12,%0" : "=m" (q[d+32]));
- asm volatile("movntdq %%xmm14,%0" : "=m" (q[d+48]));
+ asm volatile("movdqa %%xmm4,%0" : "=m" (q[d]));
+ asm volatile("movdqa %%xmm6,%0" : "=m" (q[d+16]));
+ asm volatile("movdqa %%xmm12,%0" : "=m" (q[d+32]));
+ asm volatile("movdqa %%xmm14,%0" : "=m" (q[d+48]));
}
asm volatile("sfence" : : : "memory");
kernel_fpu_end();
_
Patches currently in -mm which might be from mc@raidlab.org are
raid6-use-normal-stores-in-the-x86-x4-xor_syndrome-functions.patch
parent reply other threads:[~2026-11-22 0:25 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20261109030805.25709-1-mc@raidlab.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261122002516.51B1F1F000C4@smtp.kernel.org \
--to=akpm@linux-foundation.org \
--cc=antosha20xx@gmail.com \
--cc=ardb@kernel.org \
--cc=david.laight.linux@gmail.com \
--cc=ebiggers@kernel.org \
--cc=hch@lst.de \
--cc=magiclinan@didiglobal.com \
--cc=markus.stockhausen@collogia.de \
--cc=mc@raidlab.org \
--cc=mm-commits@vger.kernel.org \
--cc=song@kernel.org \
--cc=xiao@kernel.org \
--cc=yukuai@fygo.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox