From: Xianting Tian <xianting.tian@linux.alibaba.com>
To: Andrew Morton <akpm@linux-foundation.org>,
mm-commits@vger.kernel.org, shy828301@gmail.com,
sashal@kernel.org, linmiaohe@huawei.com, kch@nvidia.com,
adobriyan@gmail.com
Subject: Re: + mm-proc-remove-redundant-page-validation-of-pte_page.patch added to -mm tree
Date: Fri, 15 Apr 2022 22:01:13 +0800 [thread overview]
Message-ID: <98d85ec3-330b-0853-9a9c-64e908e50320@linux.alibaba.com> (raw)
In-Reply-To: <20220316211126.09A72C340E9@smtp.kernel.org>
Could you share the reason why the patch is removed? thanks
在 2022/3/17 上午5:11, Andrew Morton 写道:
> The patch titled
> Subject: fs/proc/task_mmu.c: remove redundant page validation of pte_page
> has been added to the -mm tree. Its filename is
> mm-proc-remove-redundant-page-validation-of-pte_page.patch
>
> This patch should soon appear at
> https://ozlabs.org/~akpm/mmots/broken-out/mm-proc-remove-redundant-page-validation-of-pte_page.patch
> and later at
> https://ozlabs.org/~akpm/mmotm/broken-out/mm-proc-remove-redundant-page-validation-of-pte_page.patch
>
> Before you just go and hit "reply", please:
> a) Consider who else should be cc'ed
> b) Prefer to cc a suitable mailing list as well
> c) Ideally: find the original patch on the mailing list and do a
> reply-to-all to that, adding suitable additional cc's
>
> *** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
>
> The -mm tree is included into linux-next and is updated
> there every 3-4 working days
>
> ------------------------------------------------------
> From: Xianting Tian <xianting.tian@linux.alibaba.com>
> Subject: fs/proc/task_mmu.c: remove redundant page validation of pte_page
>
> pte_page() always returns a valid page, so remove the redundant page
> validation, as we did in many other places.
>
> Link: https://lkml.kernel.org/r/20220316025947.328276-1-xianting.tian@linux.alibaba.com
> Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com>
> Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
> Cc: Alexey Dobriyan <adobriyan@gmail.com>
> Cc: Yang Shi <shy828301@gmail.com>
> Cc: Sasha Levin <sashal@kernel.org>
> Cc: Miaohe Lin <linmiaohe@huawei.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
> fs/proc/task_mmu.c | 2 --
> 1 file changed, 2 deletions(-)
>
> --- a/fs/proc/task_mmu.c~mm-proc-remove-redundant-page-validation-of-pte_page
> +++ a/fs/proc/task_mmu.c
> @@ -1873,8 +1873,6 @@ static int gather_hugetlb_stats(pte_t *p
> return 0;
>
> page = pte_page(huge_pte);
> - if (!page)
> - return 0;
>
> md = walk->private;
> gather_stats(page, md, pte_dirty(huge_pte), 1);
> _
>
> Patches currently in -mm which might be from xianting.tian@linux.alibaba.com are
>
> mm-proc-remove-redundant-page-validation-of-pte_page.patch
prev parent reply other threads:[~2022-04-15 14:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-16 21:11 + mm-proc-remove-redundant-page-validation-of-pte_page.patch added to -mm tree Andrew Morton
2022-04-15 14:01 ` Xianting Tian [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98d85ec3-330b-0853-9a9c-64e908e50320@linux.alibaba.com \
--to=xianting.tian@linux.alibaba.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=kch@nvidia.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=sashal@kernel.org \
--cc=shy828301@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox