From: Matthew Wilcox <willy@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: davem@davemloft.net, horms@verge.net.au, kuba@kernel.org,
liumh1@shanghaitech.edu.cn, marcelo.leitner@gmail.com,
mm-commits@vger.kernel.org, pshelar@ovn.org,
ulf.hansson@linaro.org, vyasevich@gmail.com
Subject: Re: + include-linux-mmh-move-nr_free_buffer_pages-from-swaph-to-mmh.patch added to -mm tree
Date: Sun, 19 Sep 2021 23:57:09 +0100 [thread overview]
Message-ID: <YUfARSO6gOV45brm@casper.infradead.org> (raw)
In-Reply-To: <20210919153850.6a4d71f155ea725e913e0450@linux-foundation.org>
On Sun, Sep 19, 2021 at 03:38:50PM -0700, Andrew Morton wrote:
> > i don't think that moving more crap into mm.h is an improvement.
> > if anything, we should be moving more things out of mm.h.
>
> nr_free_buffer_pages() is part of the page allocation API and gfp.h
> seems a more appropriate place for its declaration.
>
> I expect this would also permit a reduction in the #include sprawl?
It must ... mm.h includes gfp.h, so everything else about this patchset
should continue to work. Maybe we could even remove mm.h from some files.
prev parent reply other threads:[~2021-09-19 22:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 3:37 + include-linux-mmh-move-nr_free_buffer_pages-from-swaph-to-mmh.patch added to -mm tree akpm
2021-09-19 5:48 ` Matthew Wilcox
2021-09-19 22:38 ` Andrew Morton
2021-09-19 22:57 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUfARSO6gOV45brm@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=horms@verge.net.au \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liumh1@shanghaitech.edu.cn \
--cc=marcelo.leitner@gmail.com \
--cc=mm-commits@vger.kernel.org \
--cc=pshelar@ovn.org \
--cc=ulf.hansson@linaro.org \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox