From: Breno Leitao <leitao@debian.org>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Matthew Wilcox <willy@infradead.org>,
mm-commits@vger.kernel.org, kent.overstreet@linux.dev,
bigeasy@linutronix.de, arnd@arndb.de
Subject: Re: + radix-tree-fix-kmemleak-false-positives-on-tree-head-reassignment.patch added to mm-new branch
Date: Tue, 11 Aug 2026 02:19:36 -0700 [thread overview]
Message-ID: <anrnoSQUwz9um0SF@gmail.com> (raw)
In-Reply-To: <anri2rKW2gG28tXC@arm.com>
On Tue, Aug 11, 2026 at 09:52:42AM +0100, Catalin Marinas wrote:
> On Mon, Aug 10, 2026 at 08:18:14PM -0700, Andrew Morton wrote:
> > On Tue, 7 Jul 2026 04:26:43 -0700 Breno Leitao <leitao@debian.org> wrote:
> >
> > > > Anyway, a better diff for the first idea below. I need to do more
> > > > testing and can turn it into a proper commit (if we don't deem it
> > > > redundant because of the other min_unref_count).
> > >
> > > Thanks for it. I've reviewed it and it looks sane.
> > >
> > > I am also testing it on my side.
> >
> > This went quiet. I take it that we won't be proceeding with this
> > patch, "radix-tree: fix kmemleak false positives on tree head
> > reassignment", v2?
>
> Yeah, I think the recent heuristics additions make this annotation
> unnecessary. Well, Breno to confirm.
Agreed. I've pulled all the latest kmemleak patches into Meta's kernel
(including this one), and the false positive rate is now much lower
than before (althought I still don't have much bake time).
I'd suggest dropping this one and instead continuing to improve
kmemleak itself to avoid these false positives where possible.
That said, I'll let Meta's kernel bake a bit longer, and if more false
positives turn up I'll report back so we can decide how to proceed.
Thanks,
--breno
next prev parent reply other threads:[~2026-08-11 9:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-05 2:12 + radix-tree-fix-kmemleak-false-positives-on-tree-head-reassignment.patch added to mm-new branch Andrew Morton
2026-07-05 10:45 ` Matthew Wilcox
2026-07-05 18:15 ` Andrew Morton
2026-07-06 10:41 ` Breno Leitao
2026-07-06 11:39 ` Catalin Marinas
2026-07-06 14:53 ` Breno Leitao
2026-07-06 16:25 ` Catalin Marinas
2026-07-06 23:19 ` Catalin Marinas
2026-07-07 11:26 ` Breno Leitao
2026-07-07 14:01 ` Catalin Marinas
2026-08-11 3:18 ` Andrew Morton
2026-08-11 8:52 ` Catalin Marinas
2026-08-11 9:19 ` Breno Leitao [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-07-05 2:11 Andrew Morton
2026-07-02 22:42 Andrew Morton
2026-07-03 15:26 ` Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anrnoSQUwz9um0SF@gmail.com \
--to=leitao@debian.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bigeasy@linutronix.de \
--cc=catalin.marinas@arm.com \
--cc=kent.overstreet@linux.dev \
--cc=mm-commits@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox