Re: [PATCH mptcp-net 0/3] mptcp: pm: ignore unknown endpoint flags

[Mat Martineau <martineau@kernel.org>]

On Wed, 26 Nov 2025, Matthieu Baerts (NGI0) wrote:

> This is just a simple fix to ignore unknown endpoint flags. Recently, a
> new "laminar" flag has been added. It can be set on older kernel
> versions without effects -- which is good -- but it is strange to report
> it in the endpoints dumps if it is not supported.
>
>  # uname -r
>  6.17.9
>  # ip mptcp endpoint add 1.2.3.4 laminar  # not supported on v6.17
>  # ip mptcp endpoint
>  1.2.3.4 id 1 laminar
>
> Patch 1 fixes that, while Patch 2 validates that.
>
> Patch 3 is for mptcp-next, to correctly follow the specs and accept u32
> flags instead of u8. This doesn't change anything, but avoids
> confusions.
>
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> ---
> Matthieu Baerts (NGI0) (3):
>      mptcp: pm: ignore unknown endpoint flags
>      selftests: mptcp: pm: ensure unknown flags are ignored
>      mptcp: pm: align endpoint flags size with the NL specs

Hi Matthieu!

All three patches LGTM:

Reviewed-by: Mat Martineau <martineau@kernel.org>

See my comment on patch 2 regarding an additional fourth patch for 
net-next.

Thanks,
Mat


>
> include/uapi/linux/mptcp.h                      |  1 +
> net/mptcp/pm_netlink.c                          |  3 ++-
> net/mptcp/protocol.h                            |  4 ++--
> tools/testing/selftests/net/mptcp/pm_netlink.sh |  4 ++++
> tools/testing/selftests/net/mptcp/pm_nl_ctl.c   | 11 +++++++++++
> 5 files changed, 20 insertions(+), 3 deletions(-)
> ---
> base-commit: 690b1c68fd1e566ffa60fec98e09292cc9f04a3a
> change-id: 20251125-mptcp-pm-kern-drop-unknown-flags-e4ec71df02e7
>
> Best regards,
> -- 
> Matthieu Baerts (NGI0) <matttbe@kernel.org>
>
>
>