From: Matthieu Baerts <matttbe@kernel.org>
To: Gang Yan <yangang@kylinos.cn>, mptcp@lists.linux.dev
Subject: Re: [Patch, v2, 0/2] BCC: python: support fmod_ret
Date: Wed, 9 Apr 2025 10:26:16 +0200 [thread overview]
Message-ID: <05896fad-5182-40cd-b429-245f599990b0@kernel.org> (raw)
In-Reply-To: <cover.1744182834.git.yangang@kylinos.cn>
Hi Gang,
On 09/04/2025 09:17, Gang Yan wrote:
> Support fmod_ret, and add a useful tool for mptcp, also
> the interface can be verified with this function.
>
> ------
> Changelog:
> v2:
> - change the name of the tool to 'mptcpify'
> - fix the code style problems in mptcpify.py
> - modify 'support_fmod_ret' in __init__.py, add some comment and
> ask for suggestions to BCC devs.
>
> Hi Matt:
>
> So nice to recieve your reply. Do you think we can create a PR with v2
> patch to BCC now? The description of PR is attached below, Can you help
> me to take a look?
Thank you for the v2. I have just some small comments, but it is not
blocking, the rest looks good to me.
Then yes, please create the PR, no need to send a v3.
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
prev parent reply other threads:[~2025-04-09 8:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-09 7:17 [Patch, v2, 0/2] BCC: python: support fmod_ret Gang Yan
2025-04-09 7:17 ` [Patch, v2, 1/2] BCC: Python: Support 'fmod_ret' method for eBPF Gang Yan
2025-04-09 8:26 ` Matthieu Baerts
2025-04-09 9:29 ` Gang Yan
2025-04-09 7:17 ` [Patch, v2, 2/2] BCC: python: add a useful tool for mptcp Gang Yan
2025-04-09 8:26 ` Matthieu Baerts
2025-04-09 8:26 ` Matthieu Baerts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05896fad-5182-40cd-b429-245f599990b0@kernel.org \
--to=matttbe@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=yangang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox