From: Matthieu Baerts <matttbe@kernel.org>
To: Geliang Tang <geliang@kernel.org>, mptcp@lists.linux.dev
Cc: Geliang Tang <tanggeliang@kylinos.cn>
Subject: Re: [PATCH mptcp-next 3/3] selftests: mptcp: connect: trigger splice_eof
Date: Mon, 2 Feb 2026 11:09:14 +0100 [thread overview]
Message-ID: <09050e23-1292-4d3c-8056-b23ffbbef0b4@kernel.org> (raw)
In-Reply-To: <467dfcbcd3e11849c507db5360c3a394c3d117a5.1770023932.git.tanggeliang@kylinos.cn>
Hi Geliang,
On 02/02/2026 10:21, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
>
> Increase the sendfile count by one to ensure the transmission size
> exceeds the actual data length. This triggers the splice_eof path
> in the kernel, allowing the newly implemented MPTCP splice_eof
> interface to be exercised during testing.
>
> The change from 'count' to 'count + 1' forces the sendfile operation
> to attempt sending one more byte than available, which activates the
> end-of-file handling in the splicing logic and ensures coverage of
> the related MPTCP code paths.
I'm a bit confused: is this splice_eof interface not linked to "splice"?
Why is it used with sendfile()?
Also, what's the behaviour without the implementation of "splice_eof()"?
Was it a wrong behaviour or is it the same? What's the differences
between the situation before and after this series?
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
next prev parent reply other threads:[~2026-02-02 10:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-02 9:21 [PATCH mptcp-next 0/3] implement .splice_eof Geliang Tang
2026-02-02 9:21 ` [PATCH mptcp-next 1/3] tcp: export do_tcp_splice_eof Geliang Tang
2026-02-02 9:21 ` [PATCH mptcp-next 2/3] mptcp: implement .splice_eof Geliang Tang
2026-02-02 10:07 ` Matthieu Baerts
2026-02-03 6:36 ` Geliang Tang
2026-02-03 9:07 ` Matthieu Baerts
2026-02-02 9:21 ` [PATCH mptcp-next 3/3] selftests: mptcp: connect: trigger splice_eof Geliang Tang
2026-02-02 10:09 ` Matthieu Baerts [this message]
2026-02-03 6:26 ` Geliang Tang
2026-02-02 10:41 ` [PATCH mptcp-next 0/3] implement .splice_eof MPTCP CI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09050e23-1292-4d3c-8056-b23ffbbef0b4@kernel.org \
--to=matttbe@kernel.org \
--cc=geliang@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=tanggeliang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox