mptcp.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Mat Martineau <martineau@kernel.org>
To: Geliang Tang <geliang.tang@linux.dev>
Cc: mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp-next v13 22/32] mptcp: flush userspace pm addrs list
Date: Thu, 7 Dec 2023 16:46:55 -0800 (PST)	[thread overview]
Message-ID: <0fb0927f-fd55-84f6-6a72-64131ad53928@kernel.org> (raw)
In-Reply-To: <8206a3d8e4a1e2b93362e2a7c7e23adc15194544.1701180969.git.geliang.tang@suse.com>

On Tue, 28 Nov 2023, Geliang Tang wrote:

> This patch adds a new function mptcp_userspace_pm_flush_addrs_list()
> to free the userspace local addresses list. Invoke it when flushing
> addresses from netlink commands.
>
> Signed-off-by: Geliang Tang <geliang.tang@suse.com>
> ---
> net/mptcp/pm_netlink.c   |  2 ++
> net/mptcp/pm_userspace.c | 23 +++++++++++++++++++++++
> net/mptcp/protocol.h     |  1 +
> 3 files changed, 26 insertions(+)

Hi Geliang -

Do you have a use case in mind for the userspace flush operation? I think 
this functionality should be implemented by the userspace PM, which can 
list the subflows and then disconnect them as needed.

Thanks,

Mat

  reply	other threads:[~2023-12-08  0:46 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-28 14:21 [PATCH mptcp-next v13 00/32] userspace pm enhancements Geliang Tang
2023-11-28 14:21 ` [PATCH mptcp-next v13 01/32] mptcp: export pm_nl_get_pernet_from_msk Geliang Tang
2023-11-28 14:21 ` [PATCH mptcp-next v13 02/32] mptcp: drop mptcp_pm_get_* helpers Geliang Tang
2023-11-28 14:21 ` [PATCH mptcp-next v13 03/32] mptcp: use pernet id_bitmap in userspace pm Geliang Tang
2023-11-28 14:21 ` [PATCH mptcp-next v13 04/32] mptcp: add userspace_pm_lookup_addr_by_id helper Geliang Tang
2023-11-28 14:21 ` [PATCH mptcp-next v13 05/32] mptcp: drop lookup_by_id parameter in lookup_addr Geliang Tang
2023-11-28 14:21 ` [PATCH mptcp-next v13 06/32] mptcp: dump addrs in userspace pm list Geliang Tang
2023-11-28 14:22 ` [PATCH mptcp-next v13 07/32] mptcp: check userspace pm subflow flag Geliang Tang
2023-11-28 14:22 ` [PATCH mptcp-next v13 08/32] selftests: mptcp: add " Geliang Tang
2023-11-28 14:22 ` [PATCH mptcp-next v13 09/32] selftests: mptcp: add mptcp_lib_cleanup helper Geliang Tang
2023-11-28 14:22 ` [PATCH mptcp-next v13 10/32] selftests: mptcp: netlink: drop duplicate var ret Geliang Tang
2023-11-28 14:22 ` [PATCH mptcp-next v13 11/32] selftests: mptcp: export ret into mptcp_lib Geliang Tang
2023-11-28 14:22 ` [PATCH mptcp-next v13 12/32] selftests: mptcp: add mptcp_lib_check_output Geliang Tang
2023-11-28 14:22 ` [PATCH mptcp-next v13 13/32] selftests: mptcp: dump userspace addrs list Geliang Tang
2023-11-28 14:22 ` [PATCH mptcp-next v13 14/32] mptcp: set set_id flag when parsing addr Geliang Tang
2023-11-28 14:22 ` [PATCH mptcp-next v13 15/32] mptcp: use set_id flag when appending addr Geliang Tang
2023-11-28 14:22 ` [PATCH mptcp-next v13 16/32] mptcp: check addrs list in userspace_pm_get_local_id Geliang Tang
2023-11-28 14:22 ` [PATCH mptcp-next v13 17/32] selftests: mptcp: dump after creating id 0 subflow Geliang Tang
2023-11-28 14:22 ` [PATCH mptcp-next v13 18/32] mptcp: make pm_remove_addrs_and_subflows static Geliang Tang
2023-11-28 14:22 ` [PATCH mptcp-next v13 19/32] mptcp: add a prefix for free_local_addr_list Geliang Tang
2023-11-28 14:22 ` [PATCH mptcp-next v13 20/32] mptcp: add mptcp_pm_remove_subflows helper Geliang Tang
2023-11-28 14:22 ` [PATCH mptcp-next v13 21/32] mptcp: rm addrs and subflows before free local list Geliang Tang
2023-11-28 14:22 ` [PATCH mptcp-next v13 22/32] mptcp: flush userspace pm addrs list Geliang Tang
2023-12-08  0:46   ` Mat Martineau [this message]
2023-11-28 14:22 ` [PATCH mptcp-next v13 23/32] selftests: mptcp: flush userspace " Geliang Tang
2023-11-28 14:22 ` [PATCH mptcp-next v13 24/32] mptcp: add use_id parameter for addresses_equal Geliang Tang
2023-11-28 14:22 ` [PATCH mptcp-next v13 25/32] mptcp: add check_id for lookup_anno_list_by_saddr Geliang Tang
2023-11-28 14:22 ` [PATCH mptcp-next v13 26/32] mptcp: add userspace_pm_get_entry helper Geliang Tang
2023-11-28 14:22 ` [PATCH mptcp-next v13 27/32] mptcp: drop addr_match and id_match Geliang Tang
2023-11-28 14:22 ` [PATCH mptcp-next v13 28/32] mptcp: dup an entry when removing it Geliang Tang
2023-11-28 14:22 ` [PATCH mptcp-next v13 29/32] mptcp: add userspace pm addr entry refcount Geliang Tang
2023-11-28 14:22 ` [PATCH mptcp-next v13 30/32] selftests: mptcp: rm userspace addr with random order Geliang Tang
2023-11-28 14:22 ` [PATCH mptcp-next v13 31/32] mptcp: map v4 address to v6 when destroying subflow Geliang Tang
2023-11-28 14:22 ` [PATCH mptcp-next v13 32/32] selftests: mptcp: rm subflow with v4/v4mapped addr Geliang Tang
2023-11-28 14:33   ` selftests: mptcp: rm subflow with v4/v4mapped addr: Tests Results MPTCP CI
2023-12-04 20:35   ` MPTCP CI

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0fb0927f-fd55-84f6-6a72-64131ad53928@kernel.org \
    --to=martineau@kernel.org \
    --cc=geliang.tang@linux.dev \
    --cc=mptcp@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).