Re: [PATCH mptcp-net v4 0/2] mptcp: support MP_PRIO signals with userspace PMs

[Mat Martineau <mathew.j.martineau@linux.intel.com>]

On Tue, 28 Jun 2022, Kishen Maloor wrote:

> This patch series updates MPTCP_PM_CMD_SET_FLAGS to allow userspace PMs
> to issue MP_PRIO signals over a selected (by local and remote address+port)
> subflow in a MPTCP connection. It also adds self tests for this
> change.
>
> This patch series has been rebased to the series (in review) titled
> "Locking fixes for subflow flag changes".
>
> v2:
> -userspace_pm.sh: added a sleep after issuing the MP_PRIO signal.
>
> v3:
> -use local and remote address+port (instead of address ID) alongwith the
> connection token to select a subflow.
>
> v4:
> -fixed bug during rebase in v3.

Thanks Kishen. v4 looks good to me, and the builds look good (I pushed 
equivalent commits to github to trigger a build):

https://cirrus-ci.com/build/6289402744799232
https://github.com/multipath-tcp/mptcp_net-next/runs/7103422638

Looks like the github action got a little confused by the exact version of 
the patches not being in patchwork.


Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>

At the meeting last week Paolo said he was planning to take a look as 
well.

>
> Kishen Maloor (2):
>  mptcp: netlink: issue MP_PRIO signals from userspace PMs
>  selftests: mptcp: userspace PM support for MP_PRIO signals
>
> net/mptcp/pm_netlink.c                        | 30 ++++++--
> net/mptcp/pm_userspace.c                      | 30 ++++++++
> net/mptcp/protocol.h                          |  8 +-
> tools/testing/selftests/net/mptcp/pm_nl_ctl.c | 73 ++++++++++++++++++-
> .../selftests/net/mptcp/userspace_pm.sh       | 32 ++++++++
> 5 files changed, 165 insertions(+), 8 deletions(-)
>
> --
> 2.31.1
>
>

--
Mat Martineau
Intel