Re: [PATCH mptcp-next 3/3] selftests: mptcp: join: allow more time to send ADD_ADDR

[Geliang Tang <geliang@kernel.org>]

Hi Matt,

On Tue, 2025-09-02 at 21:01 +0200, Matthieu Baerts (NGI0) wrote:
> When many ADD_ADDR need to be sent, it can take some time to send
> each
> of them, and create new subflows. Some CIs seem to occasionally have
> issues with these tests, especially with "debug" kernels.
> 
> Two subtests will now run for a slightly longer time: the last two
> where
> 3 or more ADD_ADDR are sent during the test.
> 
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>

LGTM!

Reviewed-by: Geliang Tang <geliang@kernel.org>

Thanks,
-Geliang

> ---
>  tools/testing/selftests/net/mptcp/mptcp_join.sh | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh
> b/tools/testing/selftests/net/mptcp/mptcp_join.sh
> index
> 1028f3f931612d98e828707a9f55caa69be4a6ca..9c1ab36110850dcc35bb77e2d58
> 94d8b1dd496a0 100755
> --- a/tools/testing/selftests/net/mptcp/mptcp_join.sh
> +++ b/tools/testing/selftests/net/mptcp/mptcp_join.sh
> @@ -2266,7 +2266,8 @@ signal_address_tests()
>  		pm_nl_add_endpoint $ns1 10.0.3.1 flags signal
>  		pm_nl_add_endpoint $ns1 10.0.4.1 flags signal
>  		pm_nl_set_limits $ns2 3 3
> -		run_tests $ns1 $ns2 10.0.1.1
> +		speed=slow \
> +			run_tests $ns1 $ns2 10.0.1.1
>  		chk_join_nr 3 3 3
>  		chk_add_nr 3 3
>  	fi
> @@ -2278,7 +2279,8 @@ signal_address_tests()
>  		pm_nl_add_endpoint $ns1 10.0.3.1 flags signal
>  		pm_nl_add_endpoint $ns1 10.0.14.1 flags signal
>  		pm_nl_set_limits $ns2 3 3
> -		run_tests $ns1 $ns2 10.0.1.1
> +		speed=slow \
> +			run_tests $ns1 $ns2 10.0.1.1
>  		join_syn_tx=3 \
>  			chk_join_nr 1 1 1
>  		chk_add_nr 3 3