public inbox for mptcp@lists.linux.dev
 help / color / mirror / Atom feed
From: Geliang Tang <geliang@kernel.org>
To: Matthieu Baerts <matttbe@kernel.org>,
	Mat Martineau <martineau@kernel.org>,
	 Paolo Abeni <pabeni@redhat.com>
Cc: Gang Yan <yangang@kylinos.cn>, mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp-next v2 2/3] mptcp: allow overridden write_space to be invoked
Date: Tue, 03 Feb 2026 18:31:09 +0800	[thread overview]
Message-ID: <19b28307eb2492546fbf363ede5856447e4fe06d.camel@kernel.org> (raw)
In-Reply-To: <3a02e802-56c6-4c99-8f7d-aa618a8f46b7@kernel.org>

Hi Matt,

Thanks for your reply.

On Tue, 2026-02-03 at 10:42 +0100, Matthieu Baerts wrote:
> Hi Geliang,
> 
> On 03/02/2026 07:54, Geliang Tang wrote:
> > Hi Matt, Mat, Paolo,
> > 
> > On Sun, 2026-01-04 at 13:29 +0800, Geliang Tang wrote:
> > > From: Geliang Tang <tanggeliang@kylinos.cn>
> > > 
> > > psock may override its own sk_write_space functions. This patch
> > > ensures
> > > that the overridden sk_write_space can be invoked by MPTCP.
> > > 
> > > Note: This patch was initially included in the NVME MPTCP set.
> > 
> > This patch was initially developed to resolve the "timeout" errors
> > observed in the NVMe MPTCP tests described in [1], because NVMe TCP
> > overrides its own sk_write_space. During subsequent development, I
> > discovered that not only NVMe TCP overrides its own sk_write_space,
> > but
> > KTLS and psock also override it. 
> > 
> > Therefore, this patch is needed in all three series. To reduce
> > dependencies between these three series, I propose to merge this
> > patch
> > into the mainline first.
> 
> Just to be sure, when you say "mainline", do you mean our MPTCP tree
> with the export branch?
> 
> Because we are at the end of a cycle here, my priority is to flush
> patches that are ready or fix issues. If I'm not mistaken, this patch
> is
> needed for new features that are not in our tree, not in net or net-
> next
> trees, right?

Yes, it is needed for new features. In this case, merging it into the
export branch first is also an option. It can be sent to net-next in
the next cycle. I plan to submit the KTLS series and the NVMe series to
the KTLS and NVMe communities for feedback respectively. If this
write_space patch enters net-next early, it would be more convenient.

Thanks,
-Geliang

> 
> Cheers,
> Matt

  reply	other threads:[~2026-02-03 10:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-04  5:29 [PATCH mptcp-next v2 0/3] implement psock_update_sk_prot Geliang Tang
2026-01-04  5:29 ` [PATCH mptcp-next v2 1/3] mptcp: " Geliang Tang
2026-01-04  5:29 ` [PATCH mptcp-next v2 2/3] mptcp: allow overridden write_space to be invoked Geliang Tang
2026-02-03  6:54   ` Geliang Tang
2026-02-03  9:42     ` Matthieu Baerts
2026-02-03 10:31       ` Geliang Tang [this message]
2026-02-03 10:56         ` Matthieu Baerts
2026-02-03 11:13           ` Matthieu Baerts
2026-02-03 11:14             ` Matthieu Baerts
2026-02-04 11:56   ` Matthieu Baerts
2026-02-05  9:46     ` Geliang Tang
2026-01-04  5:29 ` [PATCH mptcp-next v2 3/3] selftests/bpf: Update sockmap tests for MPTCP Geliang Tang
2026-01-04  6:38 ` [PATCH mptcp-next v2 0/3] implement psock_update_sk_prot MPTCP CI

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19b28307eb2492546fbf363ede5856447e4fe06d.camel@kernel.org \
    --to=geliang@kernel.org \
    --cc=martineau@kernel.org \
    --cc=matttbe@kernel.org \
    --cc=mptcp@lists.linux.dev \
    --cc=pabeni@redhat.com \
    --cc=yangang@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox