Re: [mptcp-next v2 0/7] Add 'dump_subflow' test in selftests

[Matthieu Baerts <matttbe@kernel.org>]

Hi Gang,

On 16/04/2025 10:59, Gang Yan wrote:
> The 'subflow_get_info_size' is called only in 'inet_sk_attr_size', and
> the only calltrace is that 'tcp_diag_dump_one'->'inet_diag_dump_one_icsk'
> ->'inet_sk_attr_size'.
> 
> So It's necessary to add 'get_subflow_info' in mptcp_diag.c to cover this
> function. Given a specific TCP connection, it is possible to judge if
> it is a MPTCP subflow by 'INET_ULP_INFO_MPTCP' and print 'subflow_info'.

Thank you for looking at this. I have few minor comments, please check
my other replies.

> Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/524

Can you add this line in the last patch as well please? So the ticket
will be automatically closed when the patches will be applied.


Something else: can you make sure to keep the "PATCH" prefix from the
subjects? I guess you used:

  git send-email --subject-prefix mptcp-next

instead of:

  git send-email --subject-prefix "PATCH mptcp-next"

Do not hesitate to use b4 [1] to send patches, it is helpful not to
forget things when sending patches by email. (Just don't use 'b4 prep
--auto-to-cc' when submitting patches for MPTCP)

[1] https://b4.docs.kernel.org

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.