Mat Martineau <mathew.j.martineau(a)linux.intel.com> wrote:
> I had a couple of minor questions on patch 3, but nothing that would keep
> this from going in to the export branch for some more testing. Might be
> easier to coordinate with Paolo's refactor changes to the workqueue that
> way.
> 
> Do the selftests get any code coverage on this, for example in the
> new-subflow-not-allowed case?

How would you do that?  I could add a mib counter and check that in the
script.  But other than that I do not see how to expose any of this to
the script/mptcp_connect.

> And thanks for looking at packetdrill tests for this,
> saw the conversation on IRC.

Yes, I plan to send a pull request for fastclose and reset.

As for further direction, I think next step is to add genl notifications
so mptcpd can learn about subflows that are added/removed, the reset
code could then be exposed to userspace in the 'subflow was reset'
case.