From: Florian Westphal <fw at strlen.de>
To: mptcp at lists.01.org
Subject: [MPTCP] Re: [PATCH mptcp 7/7] mptcp: add netlink event support
Date: Wed, 20 Jan 2021 14:14:50 +0100 [thread overview]
Message-ID: <20210120131450.GP19605@breakpoint.cc> (raw)
In-Reply-To: 6318158a-6810-3e26-38ff-640ce7823b39@tessares.net
[-- Attachment #1: Type: text/plain, Size: 1041 bytes --]
Matthieu Baerts <matthieu.baerts(a)tessares.net> wrote:
> Hi Florian,
>
> On 20/01/2021 13:18, Florian Westphal wrote:
> > Mat Martineau <mathew.j.martineau(a)linux.intel.com> wrote:
> > > On Thu, 14 Jan 2021, Florian Westphal wrote:
> > > > #define MPTCP_PM_NAME "mptcp_pm"
> > > > #define MPTCP_PM_CMD_GRP_NAME "mptcp_pm_cmds"
> > > > +#define MPTCP_PM_EV_GRP_NAME "mptcp_events"
> > >
> > > Suggest "mptcp_pm_events" instead.
> >
> > I don't mind changing it but it would mean one more change needed
> > on mptcpd side vs. the out of tree kernel.
>
> Instinctively, I would prefer having different names just in case we need to
> do something different from one implementation to another. In userspace, we
> would only have to try one or the other but at least we will know which one
> we are connected to, "just in case" we need different behaviours for one or
> the other.
mptcp kernel uses "mptcp" as the genetlink name, not "mptcp_pm", so it
already knows if its running on mptcp.org or upstream kernel.
next reply other threads:[~2021-01-20 13:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 13:14 Florian Westphal [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-01-20 13:21 [MPTCP] Re: [PATCH mptcp 7/7] mptcp: add netlink event support Matthieu Baerts
2021-01-20 13:01 Matthieu Baerts
2021-01-20 12:55 Matthieu Baerts
2021-01-20 12:27 Florian Westphal
2021-01-20 12:18 Florian Westphal
2021-01-20 0:18 Mat Martineau
2021-01-19 21:31 Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210120131450.GP19605@breakpoint.cc \
--to=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox