From: Florian Westphal <fw@strlen.de>
To: Matthieu Baerts <matthieu.baerts@tessares.net>
Cc: Florian Westphal <fw@strlen.de>,
mptcp@lists.linux.dev, Geliang Tang <geliangtang@gmail.com>
Subject: Re: [MPTCP][PATCH v2 mptcp-next 1/4] mptcp: add sysctl allow_join_initial_addr_port
Date: Wed, 28 Apr 2021 13:03:24 +0200 [thread overview]
Message-ID: <20210428110324.GE975@breakpoint.cc> (raw)
In-Reply-To: <e05e68e1-4971-7daa-24bf-1d79b9ba89c1@tessares.net>
Matthieu Baerts <matthieu.baerts@tessares.net> wrote:
> >>> int mptcp_enabled;
> >>> unsigned int add_addr_timeout;
> >>> + int allow_join_initial_addr_port;
> >>
> >> u8 allow_join_initial_addr_port;
> >
> > Should we do the same modifications for 'mptcp_enabled'? Switch to a u8
> > with min 0 and max 1?
It would be better yes, but I was more interested to not follow the
existing example.
> Even if we typically use it with 0 and 1, modifying 'mptcp_enabled'
> might be seen as breaking the exposed userspace API, no? Maybe too late
> to change?
Such changes have been done in the past, I think its ok.
next prev parent reply other threads:[~2021-04-28 11:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 7:01 [MPTCP][PATCH v2 mptcp-next 0/4] add MP_CAPABLE 'C' flag Geliang Tang
2021-04-28 7:01 ` [MPTCP][PATCH v2 mptcp-next 1/4] mptcp: add sysctl allow_join_initial_addr_port Geliang Tang
2021-04-28 7:01 ` [MPTCP][PATCH v2 mptcp-next 2/4] mptcp: add allow_join_id0 in mptcp_out_options Geliang Tang
2021-04-28 7:01 ` [MPTCP][PATCH v2 mptcp-next 3/4] mptcp: add deny_join_id0 in mptcp_options_received Geliang Tang
2021-04-28 7:01 ` [MPTCP][PATCH v2 mptcp-next 4/4] selftests: mptcp: add deny_join_id0 testcases Geliang Tang
2021-04-28 9:43 ` [MPTCP][PATCH v2 mptcp-next 3/4] mptcp: add deny_join_id0 in mptcp_options_received Florian Westphal
2021-04-28 15:38 ` Geliang Tang
2021-04-28 9:40 ` [MPTCP][PATCH v2 mptcp-next 1/4] mptcp: add sysctl allow_join_initial_addr_port Florian Westphal
2021-04-28 10:36 ` Matthieu Baerts
2021-04-28 10:52 ` Matthieu Baerts
2021-04-28 11:03 ` Florian Westphal [this message]
2021-04-28 15:40 ` Geliang Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210428110324.GE975@breakpoint.cc \
--to=fw@strlen.de \
--cc=geliangtang@gmail.com \
--cc=matthieu.baerts@tessares.net \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox